Red Hat Bugzilla – Bug 189046
Review Request: perl-Log-Message-Simple
Last modified: 2007-11-30 17:11:30 EST
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Log-Message-Simple/perl-Log-Message-Simple.spec SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Log-Message-Simple-0.01-1.src.rpm Description: This module provides standardized logging facilities using the Log::Message module.
Some warnings running the tests; nothing serious but it should probably be reported upstream: t/03_functions....Use of uninitialized value in numeric eq (==) at t/03_functions.t line 54. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 73. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 54. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 73. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 54. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 73. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 54. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 73. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 54. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 73. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 54. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 73. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 54. Use of uninitialized value in numeric eq (==) at t/03_functions.t line 73. ok All tests successful. Files=3, Tests=97, 0 wallclock secs ( 0.21 cusr + 0.06 csys = 0.27 CPU) Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and conforms to the Perl template. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: 0c60795da495f6a79d09362e8b4f0061 Log-Message-Simple-0.01.tar.gz 0c60795da495f6a79d09362e8b4f0061 Log-Message-Simple-0.01.tar.gz-srpm * BuildRequires are proper. * package builds in mock. * rpmlint is silent. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directory it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
Oops, forgot to add: APPROVED
There's already a ticket open for the warnings: http://rt.cpan.org/Ticket/Display.html?id=18220
Imported, branches created, and builds requested.