Spec URL: http://gsd.di.uminho.pt/jpo/software/fedora/perl-Email-MIME-Modifier.spec SRPM URL: http://gsd.di.uminho.pt/jpo/software/fedora/perl-Email-MIME-1.82-2.src.rpm Description: Provides a number of useful methods for manipulating MIME messages. These method are declared in the "Email::MIME" namespace, and are used with "Email::MIME" objects.
Oops, wrong SRPM link. I'm going to assume you meant http://gsd.di.uminho.pt/jpo/software/fedora/perl-Email-MIME-Modifier-1.42-2.src.rpm Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and follows the Perl specfile template. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: 3acf1c19da93334be37f3f9a288acd91 Email-MIME-Modifier-1.42.tar.gz 3acf1c19da93334be37f3f9a288acd91 Email-MIME-Modifier-1.42.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=5, Tests=68, 0 wallclock secs ( 0.22 cusr + 0.06 csys = 0.28 CPU) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED
Thanks for the review. Imported and built for FC-4, FC-5, and devel.