Red Hat Bugzilla – Bug 190318
Review Request: perl-HTTP-Request-Params - Retrieve GET/POST Parameters from HTTP Requests
Last modified: 2007-11-30 17:11:31 EST
Spec URL: http://gsd.di.uminho.pt/jpo/software/fedora/perl-HTTP-Request-Params.spec SRPM URL: http://gsd.di.uminho.pt/jpo/software/fedora/perl-HTTP-Request-Params-1.01-1.src.rpm Description: This software does all the dirty work of parsing HTTP Requests to find incoming query parameters.
* package meets naming and packaging guidelines. * specfile is properly named, is cleanly written, uses macros consistently and follows the Perl template. * license field matches the actual license. * license is open source-compatible. It's not included separately in the package, but this is not necessary as the upstream tarball does not include it. * source files match upstream: fccd255a2992c77b5c40cb5e1e75b256 HTTP-Request-Params-1.01.tar.gz fccd255a2992c77b5c40cb5e1e75b256 HTTP-Request-Params-1.01.tar.gz-srpm * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane. * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. * %check is present and all tests pass: All tests successful. Files=1, Tests=26, 1 wallclock secs ( 0.08 cusr + 0.02 csys = 0.10 CPU) * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app. APPROVED
Thanks for the review. Imported and built for FC-4, FC-5, and devel.