Red Hat Bugzilla – Bug 198613
Review Request: compat-libgda - gnome database access library
Last modified: 2007-11-30 17:11:37 EST
Spec URL: http://www.poolshark.org/src/compat-libgda.spec
SRPM URL: http://www.poolshark.org/src/compat-libgda-1.2.3-1.src.rpm
This package provides the last stable version of libgda, from the 1.2.x tree (libgda-2.so). Since FC-5, fedora-extras has moved on to the unstable versions (1.3.x and 1.9.x), which provide libgda-3.so.
The main goal of this compat package is to package Glom, the much talked-about database design tool. Glom is based on libgdamm (already part of Extras though not currently built), which in turn requires libgda-2.so. Once built, we will be able to revive libgdamm then finally submit Glom itself for review (it will also need gnome-python2-gda).
This compat package is somewhat minimalist so as to not create conflicts with the libgda 1.9.x, and currently only enables the postgresQL module by default (because it's the only one used by Glom), however we can enable other modules in the future if some package needs it (the mysql module compiles fine with mysqlclient10).
Thanks Denis. As the maintainer of Glom, libgdamm, and pygda, and a contributor
to libgda, I'd much prefer of course that Fedora just revert their libgda
package back to the stable API. It seems silly to do all this work just to
restore a stable API. Nobody should be using the unstable API.
Fixed issue with compat-libgda configuration directory.
OK, I went to review this one, and found a few really minor issues that I fixed.
If you're ok with the minor changes, this package is approved.
Specifically, I added an xbase conditional (since xbase is in FE), enabled
everything that could be built by default in Fedora, and fixed the libraries so
that they get handled properly by debuginfo. Also, I changed Source0 so it
points to a URL. Last, I fixed the License tags for the provider packages so
that they were GPL (only the core libgda libs are LGPL) and included the LGPL
text in the main package as a %doc.
- rpmlint checks return:
W: compat-libgda-devel no-documentation
W: compat-gda-mysql no-documentation
W: compat-gda-odbc no-documentation
W: compat-gda-postgres no-documentation
W: compat-gda-sqlite no-documentation
W: compat-gda-ldap no-documentation
W: compat-gda-xbase no-documentation
- package meets naming guidelines
- package meets packaging guidelines
- license (LGPL) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR
- no unnecessary BR
- locales grabbed with find_lang
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base package n-v-r
APPROVED (assuming you use my spec)
Created attachment 136022 [details]
Updated compat-libgda spec file.
Thanks Tom, I'll use your spec file.
Of course now that this package is approved, I'm willing to bet Gnome will
release libgda 2.0 tomorrow :-)
Built for RawHide. You should be able to rebuild libgdamm now.
Please also build for FC-5. :)