Red Hat Bugzilla – Bug 199941
Review Request: gnome-python2-gda
Last modified: 2007-11-30 17:11:38 EST
Spec URL: http://www.poolshark.org/src/gnome-python2-gda.spec
SRPM URL: http://www.poolshark.org/src/gnome-python2-gda-2.14.0-1.src.rpm
Description: pyGNOME Python extension module for interacting with gda
This module should be part of the gnome-python2-extras package, which is in Core. However since libgda (the Gnome database accesslib) is in Extras, the gda module is not enabled in Core. The goal of this package is to provide that missing gda module, which is needed by Glom.
I do think the better solution would be for the stable tree of libgda to be part of Fedora Core, but one has to choose one's battles.
You'll notice some devel-type files are present in the package, which rpmlint will complain about. The spec tries to be consistent with that of gnome-python2-extras in Core, and considering the small size of the package I don't think the devel split is worth the effort.
Could you update to the 2.14.2 release thats used in core now?
Update and I can see about doing a review on this.
OK - Package name
OK - Spec file matches base package name.
OK - Meets Packaging Guidelines.
See below - License
See below - License field in spec matches
See below - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - Package compiles and builds on at least one arch.
OK - BuildRequires correct
OK - Package owns all the directories it creates.
OK - Package has no duplicate files in %files.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Spec has consistant macro usage.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package doesn't own any directories other packages own.
See below - No rpmlint output.
See below - Should include License or ask upstream to include it.
OK - Should build in mock.
1. No %dist tag?
2. Is there any good way to tell what the license is?
The COPYING file (BTW, not a very good name for that file) has a
table of module and license, but doesn't mention gda at all. ;(
There are also no headers, readme's or anything else in the gda
3. Your Source line is not correct. It's pointing to the 2.13 dir
instead of 2.14.
4. rpmlint says:
W: gnome-python2-gda devel-file-in-non-devel-package /usr/include/pygda-1.2/
W: gnome-python2-gda devel-file-in-non-devel-package /usr/lib/pkgconfig/pygda-
Unfortunately, I don't think the guidelines give much leeway on
making sure devel files go into a devel subpackage.
It's not really that much trouble to make a devel subpackage is it?
2. gda is unfortunately omitted in the COPYING file, I filed a bug upstream. The
code is released under the LGPL :
Licence field fixed, and licence files included.
3. oops nice catch, fixed.
4. no trouble at all. Devel split done.
Just one more minor issue:
The devel package has a .pc file, so it should 'Requires: pkgconfig'
You can go ahead and fix that before you import it.
All the other blockers are fixed, so this package is APPROVED.
Don't forget to close this NEXTRELEASE once it's been imported and built.
Also, do consider doing a review of another package thats waiting...
pkgconfig added. Built. Thanks for your review! :-)