Red Hat Bugzilla – Bug 200555
Review Request: libsynaptics - Synaptics touchpad driver library
Last modified: 2007-11-30 17:11:39 EST
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/libsynaptics.spec SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/libsynaptics-0.14.6b-1.fc5.src.rpm Description: A small C++ library usable by the synaptics driver. The version numbering will follow any driver releases, the appended letter marks releases due to bug fixing. This is needed by ksynaptics
Guess I need to review this one too... (:
First, Version should not contain non-numerics, (see http://www.fedoraproject.org/wiki/Packaging/NamingGuide) You should use (something like): Version: 0.14.6 Release: 1.b%{?dist} The easiest way to deal with this is to use some macro, say %beta %define beta b Then use: Release: 1.%{beta} Because of the munging of Version, you'll need to modify other bits to be (again, something like): Source0: http://qsynaptics.sourceforge.net/libsynaptics-%{version}%{?beta}.tar.bz2 ... %setup -q -n %{name}-%{version}%{?beta}
upstream source checks: 6ea2b72829df76138a9a1f03faeda438 libsynaptics-0.14.6b.tar.bz2 This one is pretty simple and straightforward. Make the recommended Version/Release modification, and I'll approve this.
Just FYI (don't know if relevant to this package or ksynaptics): devel-PPC currently is missing synaptics; see Bug 199864 for details
This is a post-release non-numeric version. It will be followed by 0.14.6c or 0.14.7, so, according to the guidelines: Post-release packages: Packages released after a "final" version. This usually is due to a quick bugfix release, such as openssl-0.9.6b or gkrellm-2.1.7a. In this case, the non-numeric characters are permitted in the Version: field. See http://qsynaptics.sourceforge.net/dl.html for historical version numbers. Thanks for the heads up on PPC. I'll do an ExcludeArch if needed. If I can avoid it I will, though we might end up with a package for ppc that just won't work.
>Post-release packages: Packages released after a "final" version Well, I'll be, didn't know about that exception, ya learn something new every day. Looks good then, approved.
Imported, built on devel, and added to owners.list.