Red Hat Bugzilla – Bug 200565
Review Request: ksynaptics - KDE configuration for synaptics module
Last modified: 2007-11-30 17:11:39 EST
Spec Name or Url: http://www.cora.nwra.com/~orion/fedora/ksynaptics.spec SRPM Name or Url: http://www.cora.nwra.com/~orion/fedora/ksynaptics-0.3.1-1.fc5.src.rpm Description: KSynaptics (previously QSynaptics) is a Qt/KDE based configuration utility for the synaptics touchpad drivers.
upstream source checks out. c9c124ba59bbb898bfc73f2ab00e8006 ksynaptics-0.3.1.tar.bz2 A few initial comments: 1. Icons need scriptlets (See http://www.fedoraproject.org/wiki/ScriptletSnippets), something like: %post touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: %postun 2. You don't really need: export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include anymore, the qt bug that this worked around is now fixed. touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||: Otherwise it looks good! Now, I'll try building and see how it works... (:
oops, left %postun blank, it should have been the same: %post touch --no-create %{_datadir}/icons/hicolor || : gtk-update-icon-cache -q %{_datadir}/icons/hicolor 2>/dev/null ||:
I'd suggest replacing: desktop-file-install --vendor=fedora \ --add-category=Qt \ --add-category=KDE \ --add-category=Utility \ --add-category=X-Fedora \ --delete-original --dir %{buildroot}%{_datadir}/applications \ $RPM_BUILD_ROOT/%{_datadir}/applications/kde/%{name}.desktop with simply: desktop-file-install \ --vendor="" --add-category=X-Fedora \ --dir $RPM_BUILD_ROOT%{_datadir}/applications/kde \ $RPM_BUILD_ROOT%{_datadir}/applications/kde/*.desktop The vendor is clear already here (kde), and this is simply a KControl module, so there's no need to add those Categories.
spec and src.rpm updated. New srpm: http://www.cora.nwra.com/~orion/fedora/ksynaptics-0.3.1-1.fc5.src.rpm though you really only need the new spe. - Add icon post/postun scripts - Add Requires: hicolor-icon-theme - Remove old QTDIR hack - Cleanup desktop file Not sure if the hicolor-icon-theme requires is necessary, but I would think so since it installs into %{_datadir}/icons/hicolor/... Thanks for the reviews Rex!
The Requires: hicolo-icon-theme probably isn't absolutely required, but I guess it doesn't hurt either. approved.
Imported, built on devel, and added to owners.list.