Bug 2038652 - Review Request: rust-nu-parser - Nushell parser
Summary: Review Request: rust-nu-parser - Nushell parser
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2075624 (view as bug list)
Depends On: 2038612 2038636
Blocks: 2038653 2038736
TreeView+ depends on / blocked
 
Reported: 2022-01-09 07:44 UTC by Michel Lind
Modified: 2022-05-07 04:26 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-04-28 05:50:40 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2022-01-09 07:44:56 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-parser.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust/rust-nu-parser-0.42.0-1.fc35.src.rpm
Description: Nushell parser.
Fedora Account System Username: salimma

Comment 1 Michel Lind 2022-04-14 17:53:58 UTC
*** Bug 2075624 has been marked as a duplicate of this bug. ***

Comment 3 Fabio Valentini 2022-04-14 18:47:30 UTC
It seems you didn't regenerate the package's spec file for 0.61.0?
Or did you remove the "plugin" and "nu-plugin" features on purpose?

--- a/rust-nu-parser.spec
+++ b/rust-nu-parser.spec
@@ -49,6 +49,30 @@ use the "default" feature of the "%{crate}" crate.
 %files       -n %{name}+default-devel
 %ghost %{crate_instdir}/Cargo.toml
 
+%package     -n %{name}+nu-plugin-devel
+Summary:        %{summary}
+BuildArch:      noarch
+
+%description -n %{name}+nu-plugin-devel %{_description}
+
+This package contains library source intended for building other packages which
+use the "nu-plugin" feature of the "%{crate}" crate.
+
+%files       -n %{name}+nu-plugin-devel
+%ghost %{crate_instdir}/Cargo.toml
+
+%package     -n %{name}+plugin-devel
+Summary:        %{summary}
+BuildArch:      noarch
+
+%description -n %{name}+plugin-devel %{_description}
+
+This package contains library source intended for building other packages which
+use the "plugin" feature of the "%{crate}" crate.
+
+%files       -n %{name}+plugin-devel
+%ghost %{crate_instdir}/Cargo.toml
+
 %prep
 %autosetup -n %{crate}-%{version_no_tilde} -p1
 %cargo_prep

Comment 4 Michel Lind 2022-04-14 19:43:25 UTC
The plugin is temporarily disabled with https://salimma.fedorapeople.org/specs/rust/rust-nu/rust-nu-parser-.rust2rpm.conf as rust-nu-plugin is not packaged yet

Comment 5 Fabio Valentini 2022-04-14 19:59:10 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches

===

If you submit both packages with the same bodhi update, you can leave the +plugin feature enabled.

Comment 6 Michel Lind 2022-04-14 22:52:22 UTC
Thanks! Yeah, plugin depends on capnp being upgraded so I'll put up a review request for it for completeness, and make it block on capnp. I can probably hold off importing it and see if I can just reenable plugin first, but will request the repos and branches now.

❯ fedpkg request-repo rust-nu-parser 2038652
https://pagure.io/releng/fedora-scm-requests/issue/43708

❯ fedpkg request-branch --repo rust-nu-parser --all-releases
https://pagure.io/releng/fedora-scm-requests/issue/43709
https://pagure.io/releng/fedora-scm-requests/issue/43710
https://pagure.io/releng/fedora-scm-requests/issue/43711

Comment 7 Gwyn Ciesla 2022-04-15 04:30:42 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-nu-parser

Comment 8 Fedora Update System 2022-04-18 21:29:18 UTC
FEDORA-2022-4f48ae2d1a has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a

Comment 9 Fedora Update System 2022-04-18 21:30:32 UTC
FEDORA-2022-40a68fac9c has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c

Comment 10 Fedora Update System 2022-04-18 21:31:21 UTC
FEDORA-2022-43bd74ffd7 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7

Comment 11 Fedora Update System 2022-04-19 17:27:26 UTC
FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-4f48ae2d1a \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-4f48ae2d1a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2022-04-20 20:24:54 UTC
FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-43bd74ffd7 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-43bd74ffd7

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2022-04-20 20:25:57 UTC
FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2022-40a68fac9c \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-40a68fac9c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2022-04-28 05:50:40 UTC
FEDORA-2022-40a68fac9c has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2022-04-28 05:53:52 UTC
FEDORA-2022-43bd74ffd7 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2022-05-07 04:26:57 UTC
FEDORA-2022-4f48ae2d1a has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.