http://togami.com/~warren/fedora/perl-Finance-YahooQuote-0.21-1.src.rpm http://togami.com/~warren/fedora/perl-Finance-YahooQuote.spec Description: Perl interface to get stock quotes from Yahoo! Finance
BuildRequires needs perl(HTTP::Request::Common) in order for mock to run %check.
Oops, we need to turn off the %check because a package build must not require network access. Thanks. http://togami.com/~warren/fedora/perl-Finance-YahooQuote-0.21-2.src.rpm http://togami.com/~warren/fedora/perl-Finance-YahooQuote.spec
Warren: I tried to build this under mock with %check enabled and a BR of perl(HTTP::Request::Common). This also results in a failure and warnings mentioned in the build log of missing packages. By using a BR of perl(HTTP::Request), this fixes the problem. perl(HTTP::Request) needs to be added to the BR in order for %check to function and should be added even though it is not used for official builds. A developer who enables the %check section would not automatically know this otherwise. The build log also indicates that rpm is adding a Requires of perl(HTTP::Request::Common), however, when I tried using this for a BR, it fails and the following warnings are shown: Warning: prerequisite HTML::Parser 2.2 not found. Warning: prerequisite HTTP::Request 1.23 not found. Warning: prerequisite LWP::UserAgent 1.62 not found. These packages do not show up as being required by rpm. Therefore, I think a "Requires: perl(HTTP::Request)" also needs to be added to the spec file. Please add this unless you can show that it is not required. ==== Review Checklist ==== - rpmlint output clean - package named according to package naming guidelines - filename matches spec's %{name} - package meets packaging guidelines - package licensed with opensource compatible license - license in spec matches actual license - license included in %doc - spec written in American english - spec file legible - sources match upstream 844d26ef02f16216840aac5815a6a6a7 Finance-YahooQuote-0.21.tar.gz - package successfully compiles and builds on FC5 x86_64 - package does not contain locales - package does not contain shared libraries/static libraries/pkgconfig files or any other files required for a devel subpackage - package is not relocatable - package does not contain duplicate files in %files - permissions on files set properly - package contains proper %clean section - macro usage is consistent - package contains code - no large documentation files - files in %doc do not affect runtime - no need for .desktop files === MUST === - Please address concerns I have about BuildRequires and Requires issues I mention above.
I've looked into this problem a bit more and the root.log is showing that using perl(HTTP::Request::Common) brings in the mod_perl package instead of the perl-libwww-perl package. Should mod_perl be Providing perl(HTTP::Request::Common)?
Ok, I found the problem, see bug #208348
This package is currently approved for FC7+ only. mod_perl-2.0.3-3 must be built for FC6/FC5 before branching to those releases. See bug #197841 for more information.
Imported and branched on FC5 and FC6. (mod_perl while problematic was a non-issue for this.)