Spec URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/thunar-archive-plugin.spec SRPM URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/thunar-archive-plugin-0.2.2-1.fc7.src.rpm Description: The Thunar Archive Plugin allows you to create and extract archive files using the file context menus in the Thunar file manager. Starting with version 0.2.0, the plugin provides a generic scripting interface for archive managers and File Roller is no longer hardcoded. Note: xarchiver (bug #198098) is also supported, ark is not working ATM. This is because the mimetypes are not registered correctly by kdeutils.
It seems to me that 'and File Roller is no longer hardcoded.' could be removed from %description. It doesn't really work for me. Icons have appeared, but 'extract to...' fails with a pop-up window Failed to extract files. No suitable archive manager found.
(In reply to comment #1) > It seems to me that 'and File Roller is no longer hardcoded.' could > be removed from %description. ok. > It doesn't really work for me. Icons have appeared, but 'extract to...' > fails with a pop-up window > Failed to extract files. > No suitable archive manager found. Works fine here with file-manager and xarchiver (if installed). I can even select which one to use. Please give me ls -l /usr/libexec/thunar-archive-plugin/ and ls -l /usr/share/applications/gnome-file-roller* The name of the desktop-file in /usr/share/applications has to match the file in /usr/libexec/thunar-archive-plugin, this is why i have renamed file-roller.tap to gnome-file-roller.tap.
(In reply to comment #2) > Works fine here with file-manager of course i meant file-roller. Another thing I forgot to mention: the mime type has tp be registered to file-roller, this is why ark is not working ATM. Does file-roller show up in the menu when you right click on an archive in Thunar or nautilus?
I don't have file-roller installed. Maybe a Requires missing?
In fact the default Requires should certainly be xarchiver, it is more xfce-like.
This is another case of require foo or bar... ATM you need ether file-roller or xarchiver (or you can use both) but I don't want to force people to install file-roller. xarchiver would be ok for me, but I don't really like it. One can easily add his own program to the plugin, a wrapper template is included in the docs.
(In reply to comment #6) > This is another case of require foo or bar... > > ATM you need ether file-roller or xarchiver (or you can use both) but I don't > want to force people to install file-roller. xarchiver would be ok for me, but I > don't really like it. One can easily add his own program to the plugin, a > wrapper template is included in the docs. This is something for end-users, we shouldn't force them to do anything to have it working. In my opinion using xarchiver should be the best. A virtual provides would be the cleanest, but I don't think it is really necessary in that case since there is an xfce-like application.
Ok, I will update the package, wait a moment. The changes so far are: - Require xarchiver. - Shorten %description. (comment #1) - Fix Source0 URL. - Use thunarver macro. - Include template.tap to %%doc. (the one from comment #6)
Here are the updated files: SPEC: http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/thunar-archive-plugin.spec SRPM: http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/thunar-archive-plugin-0.2.2-2.fc7.src.rpm
Now that we have a Requires: on xarchiver, why not remove %dir %{_libexecdir}/thunar-archive-plugin/ from the packge? This would avoid the duplicate ownership of this dir by xarchiver and thuar-archive-plugin.
I would have personally kept the dir ownership in both packages, but you can remove it from thunar-archive-plugin if you want.
Whats the status on this package? Patrice: Do you want to do a formal review of it? Or would you like me to do so?
Yes, I'll do the formal review.
* rpmlint is silent X license seems to be LGPL, license included but is GPL in specfile * follow guidelines * match upstream a164326a32a64063079405da11677f0a thunar-archive-plugin-0.2.2.tar.bz2 * sane provides, with the usual bogus dlopened module useless soname: Provides: thunar-archive-plugin.so * own directories, /usr/lib/thunarx-1/ should be owned by thunar * build and works correctly out of the box * BuildRequires and Requires seem to be right It is not obvious that the gtk cache update is needed, but I guess it is needed for the icons in the right-click thunar menu? The scriptlet snippet isn't the same than in the guidelines but the one proposed here should be right, too. The only real issue pending is the License issue. This is APPROVED if you fix it, no need to repost a srpm if it is the only difference.
(In reply to comment #14) > * rpmlint is silent > X license seems to be LGPL, license included but is GPL in specfile Sorry, my fault. COPYING and headers are LGPL, so the specfile is wrong. > It is not obvious that the gtk cache update is needed, but I guess it > is needed for the icons in the right-click thunar menu? I did not really test if it's necessary, I just strictly followed the guidelines. The guidelines tell you to run gtk-update-icon-cache, "If an application installs icons into one of the subdirectories in %{_datadir}/icons". > The scriptlet snippet isn't the same than in the guidelines but the > one proposed here should be right, too. Oops, I copied it over from another specfile, obviously the Scriptlet Snipplets in the Wiki have changed in the meantime. The page I used is http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=recall&rev=1#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda > The only real issue pending is the License issue. This is APPROVED if you > fix it, no need to repost a srpm if it is the only difference. OK, thanks a lot for reviewing this so carefully. I will fix the license issue after import into CVS. I will also update the icon cache scriptlet (if it is really needed).
24930 (thunar-archive-plugin): Build on target fedora-development-extras succeeded. Build logs may be found at http://buildsys.fedoraproject.org/logs/fedora-development-extras/24930-thunar-archive-plugin-0.2.2-2.fc7/ Closing. P.S.: Just for the record: running gtk-update-icon-cache really is needed, otherwise you will see stock_broken_image in Thunar's right click menu.