Spec URL: http://thomas.apestaart.org/download/pkg/fedora-5-x86_64-extras/python-twisted-conch-0.7.0-3.fc5/python-twisted-conch.spec SRPM URL: http://thomas.apestaart.org/download/pkg/fedora-5-x86_64-extras/python-twisted-conch-0.7.0-3.fc5/python-twisted-conch-0.7.0-3.fc5.src.rpm Description: Twisted is an event-based framework for internet applications. Conch is an SSHv2 implementation written in Python. SSH is a protocol designed to allow remote access to shells and commands, but it is generic enough to allow everything from TCP forwarding to generic filesystem access. Since conch is written in Python, it interfaces well with other Python projects, such as Imagination. Conch also includes a implementations of the telnet and vt102 protocols, as well as support for rudamentary line editing behaviors. A new implementation of Twisted's Manhole application is also included, featuring server-side input history and interactive syntax coloring.
See below - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 0236162d53cf7f34ed341d9179e7783b TwistedConch-0.7.0.tar.bz2 0236162d53cf7f34ed341d9179e7783b TwistedConch-0.7.0.tar.bz2.1 See below - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. x86_64/i386 - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: See below - Should build in mock. i386/x86_64 - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. Same comment as from the python-twisted-names review about the %{python} macro You will be maintaining these packages so it's your call, but it doesn't do anything useful for this fedora extras spec IMHO. 2. Might add the LICENSE and NEWS files in as %doc? 3. Needs BuildRequires: python-devel for fc7/devel. 4. rpmlint says: E: python-twisted-conch no-binary (which can be ignored in this case)
http://thomas.apestaart.org/download/pkg/fedora-6-i386-extras/python-twisted-conch-0.7.0-4.fc6/ incorporated changes suggested
All those changes look good... 1 isn't really a blocker. 2 and 3 are fixed. 4 isn't a issue. I don't see any blockers, this package is APPROVED. Don't forget to close this review request with NEXTRELEASE once it's been imported and built.
imported, waiting for branch to build