Red Hat Bugzilla – Bug 222072
Review Request: libdockapp - DockApp Development Standard Library
Last modified: 2007-11-30 17:11:52 EST
Spec URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/libdockapp.spec
SRPM URL: http://www.environnement.ens.fr/perso/dumas/fc-srpms/libdockapp-0.6.1-1.src.rpm
LibDockApp is a library that provides a framework for developing dockapps.
It provides functions and structures to define and display command-line
options, create a dockable icon, handle events, etc.
The goal of the library is to provide a simple, yet clean interface and
standardize the ways in which dockapps are developed. A dockapp developed
using libDockApp will automatically behave well under most window
managers, and especially well under Window Maker.
mock build is sucessfull and rpmlint reported error on libdockapp-fonts RPM
E: libdockapp-fonts zero-length /usr/share/x11/fonts/dockapp/fonts.alias
I removed the unusefull empty fonts.alias file here:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and RPMS.
+ source files match upstream.
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible. License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code as well as content(fonts).
+ no static libraries present.
+ no .pc file present.
+ -devel subpackage exists
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ fonts scriptlets used.
+ file permissions are appropriate.
imported, owners edited, built in devel, branches requested.
Thanks for the review.