Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://music.fedorapeople.org/rust-libdeflate-sys.spec SRPM URL: https://music.fedorapeople.org/rust-libdeflate-sys-1.19.0-1.fc40.src.rpm Description: Bindings to libdeflate for DEFLATE (de)compression exposed as non- streaming buffer operations. Contains bindings for raw deflate, zlib, and gzip data. Fedora Account System Username: music This review request is for unretirement of rust-libdeflate-sys[1] under the Package Retirement Policy[2]; the uploaded package corresponds to a PR[3] that would be merged upon unretirement. This package is in the dependency tree for python-cramjam, which is needed for current versions of python-fastavro. It would become a neuro-sig package (in addition to a rust-sig package). [1] https://src.fedoraproject.org/rpms/rust-libdeflate-sys [2] https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming. [3] https://src.fedoraproject.org/rpms/rust-libdeflate-sys/pull-request/1
Copr build: https://copr.fedorainfracloud.org/coprs/build/6867036 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2256974-rust-libdeflate-sys/fedora-rawhide-x86_64/06867036-rust-libdeflate-sys/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/rust-libdeflate-sys Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (Apache-2.0) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) === Some non-blocking comments / feedback: - Thank you for working to link with system libdeflate instead of the bundled copy! I assume that you wanted to replace <LINK> with a link to an upstream PR? - When re-importing the package after the unretirement, please take care wrt/ changelog. Sometimes un-retirements of packages that use rpmautospec result in weird and / or a lot of missing changelog entries. - You can commit a rust2rpm.toml config file into dist-git to preserve the libdeflate-devel dependency: ``` [requires] build = ["pkgconfig(libdeflate)"] lib = ["pkgconfig(libdeflate)"] ```
(In reply to Fabio Valentini from comment #2) > Some non-blocking comments / feedback: > > - Thank you for working to link with system libdeflate instead of the > bundled copy! > I assume that you wanted to replace <LINK> with a link to an upstream PR? Thanks! I thought I updated that, but it looks like I only fixed the PR[1] and not the .src.rpm I provided for review. > - When re-importing the package after the unretirement, please take care > wrt/ changelog. Sometimes un-retirements of packages that use rpmautospec > result in weird and / or a lot of missing changelog entries. Good point. I’ll check the changelogs and use a changelog file to override the history if needed. > - You can commit a rust2rpm.toml config file into dist-git to preserve the > libdeflate-devel dependency: > > ``` > [requires] > build = ["pkgconfig(libdeflate)"] > lib = ["pkgconfig(libdeflate)"] > ``` Thanks. That matches what I have in the PR[2]. [1] https://src.fedoraproject.org/rpms/rust-libdeflate-sys/pull-request/1#_7__20 [2] https://src.fedoraproject.org/rpms/rust-libdeflate-sys/pull-request/1#_8__2
Thank you for the review. I opened the releng ticket for unretirement, https://pagure.io/releng/issue/11873.
FEDORA-2024-e82b6c9700 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e82b6c9700
FEDORA-2024-e82b6c9700 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-5446a7b08a has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-5446a7b08a
FEDORA-EPEL-2024-5446a7b08a has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-5446a7b08a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-080062b0df has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-080062b0df
FEDORA-2024-0407cd3e71 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407cd3e71
FEDORA-2024-080062b0df has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-080062b0df \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-080062b0df See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-0407cd3e71 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0407cd3e71 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0407cd3e71 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-5446a7b08a has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-080062b0df has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-0407cd3e71 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.