Bug 2258188 - Review Request: rust-compare - Experimental comparators for collections to be generic over
Summary: Review Request: rust-compare - Experimental comparators for collections to be...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/compare
Whiteboard:
Depends On:
Blocks: 2258190 2258191
TreeView+ depends on / blocked
 
Reported: 2024-01-13 03:50 UTC by Michel Lind
Modified: 2024-01-29 04:30 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-19 20:45:26 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2024-01-13 03:50:34 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-compare.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-compare-0.1.0-1.fc38.src.rpm

Description:
Experimental comparators for collections to be generic over.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-14 01:01:01 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6894926
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258188-rust-compare/fedora-rawhide-x86_64/06894926-rust-compare/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-18 23:26:09 UTC
Please drop the "deploy-docs.sh" file from the -devel subpackage.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Please drop the "deploy-docs.sh" file from the -devel subpackage.

Comment 3 Fedora Admin user for bugzilla script actions 2024-01-19 20:31:13 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-compare

Comment 4 Michel Lind 2024-01-19 20:34:02 UTC
(In reply to Fabio Valentini from comment #2)
> Please drop the "deploy-docs.sh" file from the -devel subpackage.
> 
Good catch, thanks!

Comment 5 Fedora Update System 2024-01-19 20:44:51 UTC
FEDORA-2024-1f980913f8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1f980913f8

Comment 6 Fedora Update System 2024-01-19 20:45:26 UTC
FEDORA-2024-1f980913f8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-01-19 21:25:10 UTC
FEDORA-2024-6d5d6eddeb has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6d5d6eddeb

Comment 8 Fedora Update System 2024-01-20 03:25:53 UTC
FEDORA-2024-3ef82e8a0b has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-3ef82e8a0b \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-3ef82e8a0b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-01-20 04:26:00 UTC
FEDORA-2024-6d5d6eddeb has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6d5d6eddeb \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6d5d6eddeb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-01-28 03:08:35 UTC
FEDORA-2024-3ef82e8a0b has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2024-01-29 04:30:47 UTC
FEDORA-2024-6d5d6eddeb has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.