Bug 2258191 - Review Request: rust-uu_sort - sort ~ (uutils) sort input lines
Summary: Review Request: rust-uu_sort - sort ~ (uutils) sort input lines
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/uu_sort
Whiteboard:
Depends On: 2258188 2258190
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-01-13 03:57 UTC by Michel Lind
Modified: 2024-01-31 02:04 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-26 03:39:16 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Michel Lind 2024-01-13 03:57:42 UTC
Spec URL: https://salimma.fedorapeople.org/specs/rust-uu_sort.spec
SRPM URL: https://salimma.fedorapeople.org/specs/rust-uu_sort-0.0.23-1.fc38.src.rpm

Description:
sort ~ (uutils) sort input lines.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-01-14 01:00:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6894928
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258191-rust-uu_sort/fedora-rawhide-x86_64/06894928-rust-uu_sort/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-01-25 21:08:15 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- licenses of statically linked dependencies are correctly taken into account
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fabio Valentini 2024-01-25 21:10:03 UTC
> - latest version of the crate is packaged

This is actually a lie. v0.0.24 was released recently, but that version will need to be pushed in coordination with all other uu_* crate updates, so packaging v0.0.23 is fine for now.

Comment 4 Fedora Admin user for bugzilla script actions 2024-01-26 02:58:36 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-uu_sort

Comment 5 Michel Lind 2024-01-26 03:00:03 UTC
Thanks! Oh that fast, I was just noticing uu_dircolors' issue will be fixed in 0.0.24 and now it's out

Comment 6 Fedora Update System 2024-01-26 03:32:57 UTC
FEDORA-2024-978a020190 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-978a020190

Comment 7 Fedora Update System 2024-01-26 03:39:16 UTC
FEDORA-2024-978a020190 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-01-26 22:48:21 UTC
FEDORA-2024-e3fce4c435 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e3fce4c435

Comment 9 Fedora Update System 2024-01-26 22:49:04 UTC
FEDORA-2024-fec7e507cf has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-fec7e507cf

Comment 10 Fedora Update System 2024-01-27 02:35:09 UTC
FEDORA-2024-e3fce4c435 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e3fce4c435 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e3fce4c435

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-01-27 03:05:53 UTC
FEDORA-2024-fec7e507cf has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fec7e507cf \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fec7e507cf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-01-31 01:42:24 UTC
FEDORA-2024-fec7e507cf has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-01-31 02:04:29 UTC
FEDORA-2024-e3fce4c435 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.