Spec URL: https://salimma.fedorapeople.org/specs/rust-binary-heap-plus.spec SRPM URL: https://salimma.fedorapeople.org/specs/rust-binary-heap-plus-0.5.0-1.fc38.src.rpm Description: Enhanced version of std::collections::BinaryHeap that supports max, min, and custom-order heaps. Fedora Account System Username: salimma
Copr build: https://copr.fedorainfracloud.org/coprs/build/6894927 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258190-rust-binary-heap-plus/fedora-rawhide-x86_64/06894927-rust-binary-heap-plus/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There are some minor issues as pointed out by rpmlint: rust-binary-heap-plus-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/binary-heap-plus-0.5.0/benches/binary_heap.rs rust-binary-heap-plus-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/binary-heap-plus-0.5.0/CHANGELOG.md rust-binary-heap-plus-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/cargo/registry/binary-heap-plus-0.5.0/README.md rust-binary-heap-plus-devel.noarch: E: summary-too-long Enhanced version of std::collections::BinaryHeap that supports max, min, and custom-order heaps rust-binary-heap-plus+serde-devel.noarch: E: summary-too-long Enhanced version of std::collections::BinaryHeap that supports max, min, and custom-order heaps rust-binary-heap-plus+default-devel.noarch: E: summary-too-long Enhanced version of std::collections::BinaryHeap that supports max, min, and custom-order heaps - use dos2unix --keepdate to convert the files with CRLF line endings to LF line endings - shorten the package summary Another minor issue: - exclude appveyor.yml from installed files
Fixed, thanks [fedora-review-service-build]
Created attachment 2009367 [details] The .spec file difference from Copr build 6894927 to 6923984
Copr build: https://copr.fedorainfracloud.org/coprs/build/6923984 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2258190-rust-binary-heap-plus/fedora-rawhide-x86_64/06923984-rust-binary-heap-plus/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
looks like rust-compare is not in the Rawhide compose yet
[fedora-review-service-build]
Technically running dos2unix should happen in %prep, but you would need to move the dos2unix dependency from being a statically defined dynamically generated depepdency to actually being spelled out "BuildRequires: dos2unix". :) Other than that, package looks good to me now, thank you. === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
(In reply to Fabio Valentini from comment #8) > Technically running dos2unix should happen in %prep, but you would need to > move the dos2unix dependency from being a statically defined dynamically > generated depepdency to actually being spelled out "BuildRequires: > dos2unix". :) yeah, I tried that then moved it. Since I still need to manually invoke dos2unix anyway, might as well move back to a static BR. Thanks!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-binary-heap-plus
FEDORA-2024-5d3d080a99 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5d3d080a99
FEDORA-2024-5d3d080a99 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-e6bdce593a has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e6bdce593a
FEDORA-2024-ba384417a7 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ba384417a7
FEDORA-2024-ba384417a7 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-ba384417a7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-ba384417a7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-e6bdce593a has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e6bdce593a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e6bdce593a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-ba384417a7 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-e6bdce593a has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.