Bug 2310831 - Review Request: rust-atoi - Parse integers directly from [u8] slices in safe code
Summary: Review Request: rust-atoi - Parse integers directly from [u8] slices in safe ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/atoi
Whiteboard:
: 2268045 (view as bug list)
Depends On:
Blocks: 2279537 2279542 2279544 2279546
TreeView+ depends on / blocked
 
Reported: 2024-09-09 12:03 UTC by Cristian Le
Modified: 2024-09-11 02:57 UTC (History)
3 users (show)

Fixed In Version: rust-atoi-2.0.0-1.fc42
Clone Of:
Environment:
Last Closed: 2024-09-10 08:11:45 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Cristian Le 2024-09-09 12:03:11 UTC
Spec URL: https://lecris.fedorapeople.org/reviews/rust-atoi/rust-atoi.spec
SRPM URL: https://lecris.fedorapeople.org/reviews/rust-atoi/rust-atoi-2.0.0-1.fc42.src.rpm

Description:
Parse integers directly from `[u8]` slices in safe code.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=123151519

rust2rpm.toml
```toml
[scripts.prep]
post = [
    "# Do not depend on criterion; it is needed only for benchmarks.",
    "tomcli set Cargo.toml del dev-dependencies.criterion",
]

[requires]
build = [
    "tomcli",
]
```

Comment 1 Cristian Le 2024-09-09 12:14:04 UTC
*** Bug 2268045 has been marked as a duplicate of this bug. ***

Comment 2 Fabio Valentini 2024-09-09 22:41:53 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Cristian Le 2024-09-10 07:29:57 UTC
Thank you for the review, Fabio

Comment 4 Fedora Admin user for bugzilla script actions 2024-09-10 07:30:11 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-atoi

Comment 5 Fedora Update System 2024-09-10 07:53:20 UTC
FEDORA-2024-9e84bda444 (rust-atoi-2.0.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-9e84bda444

Comment 6 Fedora Update System 2024-09-10 08:11:45 UTC
FEDORA-2024-9e84bda444 (rust-atoi-2.0.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-09-10 08:30:02 UTC
FEDORA-2024-2941b7c862 (rust-atoi-2.0.0-1.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-2941b7c862

Comment 8 Fedora Update System 2024-09-10 08:30:02 UTC
FEDORA-2024-03d31a62e4 (rust-atoi-2.0.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-03d31a62e4

Comment 9 Fedora Update System 2024-09-10 08:30:02 UTC
FEDORA-2024-20aa1bfba9 (rust-atoi-2.0.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-20aa1bfba9

Comment 10 Fedora Update System 2024-09-11 02:28:10 UTC
FEDORA-2024-03d31a62e4 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-03d31a62e4`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-03d31a62e4

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-09-11 02:54:28 UTC
FEDORA-2024-2941b7c862 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2941b7c862`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2941b7c862

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-09-11 02:57:13 UTC
FEDORA-2024-20aa1bfba9 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-20aa1bfba9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-20aa1bfba9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.


Note You need to log in before you can comment on or make changes to this bug.