Bug 2308058 - Review Request: golang-github-dlasky-gotk3-layershell - Gotk3 addon module that provides gtk_layer_shell compatibility
Summary: Review Request: golang-github-dlasky-gotk3-layershell - Gotk3 addon module th...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2308057
Blocks: 2308060 2308061 2308062
TreeView+ depends on / blocked
 
Reported: 2024-08-26 22:54 UTC by Neal Gompa
Modified: 2024-08-27 13:01 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-08-27 13:01:46 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Neal Gompa 2024-08-26 22:54:23 UTC
Spec URL:  https://ngompa.fedorapeople.org/for-review/golang-github-dlasky-gotk3-layershell.spec
SRPM URL:  https://ngompa.fedorapeople.org/for-review/golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc40.src.rpm

Description: Gotk3 addon module that provides gtk_layer_shell compatibility

Fedora Account System Username: ngompa

Comment 1 Fedora Review Service 2024-08-26 22:54:46 UTC
There seems to be some problem with the following file.
SRPM URL: https://ngompa.fedorapeople.org/for-review/golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc42.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-08-26 23:09:48 UTC
[fedora-review-service-build]

Comment 3 Fedora Review Service 2024-08-26 23:10:19 UTC
There seems to be some problem with the following file.
SRPM URL: https://ngompa.fedorapeople.org/for-review/golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc42.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Neal Gompa 2024-08-26 23:10:47 UTC
[fedora-review-service-build]

Comment 5 Fedora Review Service 2024-08-26 23:11:19 UTC
There seems to be some problem with the following file.
SRPM URL: https://ngompa.fedorapeople.org/for-review/golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc42.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Fedora Review Service 2024-08-26 23:14:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7946218
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2308058-golang-github-dlasky-gotk3-layershell/fedora-rawhide-x86_64/07946218-golang-github-dlasky-gotk3-layershell/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 8 Mikel Olasagasti Uranga 2024-08-27 12:16:55 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 9 Fedora Admin user for bugzilla script actions 2024-08-27 12:20:54 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dlasky-gotk3-layershell

Comment 10 Fedora Update System 2024-08-27 12:59:10 UTC
FEDORA-2024-7f382f5a74 (golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-7f382f5a74

Comment 11 Fedora Update System 2024-08-27 12:59:19 UTC
FEDORA-2024-ae730fa570 (golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-ae730fa570

Comment 12 Fedora Update System 2024-08-27 13:01:46 UTC
FEDORA-2024-7f382f5a74 (golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2024-08-27 13:01:53 UTC
FEDORA-2024-ae730fa570 (golang-github-dlasky-gotk3-layershell-0-0.1.20240825git5c5115f.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.