Bug 2308060 - Review Request: nwg-bar - GTK3-based button bar for wlroots-based compositors
Summary: Review Request: nwg-bar - GTK3-based button bar for wlroots-based compositors
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2307799 2307800 2307801 2308057 2308058
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-08-26 23:01 UTC by Neal Gompa
Modified: 2024-08-27 13:46 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-08-27 13:46:44 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Neal Gompa 2024-08-26 23:01:42 UTC
Spec URL: https://ngompa.fedorapeople.org/for-review/nwg-bar.spec
SRPM URL: https://ngompa.fedorapeople.org/for-review/nwg-bar-0.1.6-1.fc40.src.rpm
Description: GTK3-based button bar for wlroots-based compositors.

Fedora Account System Username: ngompa

Comment 1 Fedora Review Service 2024-08-26 23:03:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7946184
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2308060-nwg-bar/fedora-rawhide-x86_64/07946184-nwg-bar/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Mikel Olasagasti Uranga 2024-08-27 12:18:01 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 3 Fedora Admin user for bugzilla script actions 2024-08-27 12:25:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/nwg-bar

Comment 4 Fedora Update System 2024-08-27 13:43:25 UTC
FEDORA-2024-02b1aceb12 (nwg-bar-0.1.6-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-02b1aceb12

Comment 5 Fedora Update System 2024-08-27 13:44:26 UTC
FEDORA-2024-e09967a4d4 (nwg-bar-0.1.6-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-e09967a4d4

Comment 6 Fedora Update System 2024-08-27 13:46:44 UTC
FEDORA-2024-02b1aceb12 (nwg-bar-0.1.6-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 7 Fedora Update System 2024-08-27 13:46:51 UTC
FEDORA-2024-e09967a4d4 (nwg-bar-0.1.6-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.