Spec URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SPECS/xfce4-places-plugin.spec SRPM URL: http://home.arcor.de/christoph.wickert/fedora/extras/review/SRPMS/xfce4-places-plugin-0.2.0-1.fc7.src.rpm Description: A menu with quick access to folders, documents, and removable media. The Places plugin brings much of the functionality of GNOME’s Places menu to Xfce. It puts a simple button on the panel. Clicking on this button opens up a menu with 4 sections: 1) System-defined directories (home folder, trash, desktop, file system) 2) Removable media (using thunar-vfs) 3) User-defined bookmarks (reads ~/.gtk-bookmarks) 4) Recent documents submenu (requires GTK v2.10 or greater)
I'd be happy to review this package. Look for a full review in a few.
OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License(GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: fc9828001674e7428ef4023e4a320c87 xfce4-places-plugin-0.2.0.tar.bz2 fc9828001674e7428ef4023e4a320c87 xfce4-places-plugin-0.2.0.tar.bz2.1 OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Same minor non blocking comment about the Requires for xfce4-panel being 4.4.0. If we know we are building against 4.4.1, shouldn't we require that? Shouldn't matter much however. I see no blockers, this package is APPROVED. Don't forget to close this review request once it's been imported and built.
(In reply to comment #2) > 1. Same minor non blocking comment about the Requires for xfce4-panel being 4.4.0. > If we know we are building against 4.4.1, shouldn't we require that? same as in bug #238348 comment #3 New Package CVS Request ======================= Package Name: xfce4-places-plugin Short Description: Places menu for the Xfce panel Owners: fedora Branches: FC-6 InitialCC: kevin
Package Change Request ====================== Package Name: xfce4-places-plugin New Branches: epel7 Owners: cwickert InitialCC: nonamedotc
Git done (by process-git-requests).