I would like to become the package maintainer for the orphaned ceres-solver package. I'm not yet a package maintainer so as indicated in the official documentation I'm opening a review like a new package. Spec URL: https://src.fedoraproject.org/rpms/ceres-solver/blob/rawhide/f/ceres-solver.spec SRPM URL: https://kojipkgs.fedoraproject.org//packages/ceres-solver/2.2.0/7.fc43/src/ceres-solver-2.2.0-7.fc43.src.rpm Description: Ceres Solver is an open source C++ library for modeling and solving large, complicated optimization problems. It is a feature rich, mature and performant library which has been used in production at Google since 2010. Notable use of Ceres Solver is for the image alignment in Google Maps and for vehicle pose in Google Street View. Ceres Solver can solve two kinds of problems. 1. Non-linear Least Squares problems with bounds constraints. 2. General unconstrained optimization problems. Features include: - A friendly API: build your objective function one term at a time - Automatic and numeric differentiation - Robust loss functions - Local parameterizations - Threaded Jacobian evaluators and linear solvers - Trust region solvers with non-monotonic steps (Levenberg-Marquardt and Dogleg (Powell & Subspace)) - Line search solvers (L-BFGS and Nonlinear CG) - Dense QR and Cholesky factorization (using Eigen) for small problems - Sparse Cholesky factorization (using SuiteSparse) for large sparse problems - Specialized solvers for bundle adjustment problems in computer vision - Iterative linear solvers for general sparse and bundle adjustment problems - Runs on Linux, Windows, Mac OS X, Android, and iOS Fedora Account System Username:
Copr build: https://copr.fedorainfracloud.org/coprs/build/9953772 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425618-ceres-solver/fedora-rawhide-x86_64/09953772-ceres-solver/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks for your interest in bringing this back to Fedora. It builds on f42 and f43, but does not build on rawhide because Eigen3 cannot be found, see: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425618-ceres-solver/fedora-rawhide-x86_64/09953772-ceres-solver/builder-live.log.gz Please package a commit that can use version 5 of Eigen3: https://github.com/ceres-solver/ceres-solver/blob/master/CMakeLists.txt#L248
(In reply to Benson Muite from comment #2) > Thanks for your interest in bringing this back to Fedora. It builds on f42 > and f43, but > does not build on rawhide because Eigen3 cannot be found, see: > https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora- > review-2425618-ceres-solver/fedora-rawhide-x86_64/09953772-ceres-solver/ > builder-live.log.gz > Please package a commit that can use version 5 of Eigen3: > https://github.com/ceres-solver/ceres-solver/blob/master/CMakeLists.txt#L248 I've backported a upstream patch in order to support Eigen3 version 5. Spec URL: https://pagure.io/ceres-solver/blob/master/f/ceres-solver.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/fabio/ceres-solver/fedora-rawhide-x86_64/09959323-ceres-solver/ceres-solver-2.2.0-8.fc44.src.rpm
Created attachment 2120544 [details] The .spec file difference from Copr build 9953772 to 9961716
Copr build: https://copr.fedorainfracloud.org/coprs/build/9961716 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2425618-ceres-solver/fedora-rawhide-x86_64/09961716-ceres-solver/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/ceres-solver Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I forgot to say that since this is my first package I need a sponsor. Thanks
Link to spec file should allow direct download of the spec file: spec: https://pagure.io/ceres-solver/raw/master/f/ceres-solver.spec srpm: https://download.copr.fedorainfracloud.org/results/fabio/ceres-solver/fedora-rawhide-x86_64/09959323-ceres-solver/ceres-solver-2.2.0-8.fc44.src.rpm
spec: https://download.copr.fedorainfracloud.org/results/fabio/ceres-solver/fedora-rawhide-x86_64/09959323-ceres-solver/ceres-solver.spec srpm: https://download.copr.fedorainfracloud.org/results/fabio/ceres-solver/fedora-rawhide-x86_64/09959323-ceres-solver/ceres-solver-2.2.0-8.fc44.src.rpm
Waiting for your pull request to be merged: https://src.fedoraproject.org/rpms/ceres-solver/pull-request/8 As a packager you will be able to bring in other software into Fedora, and to review software being brought into Fedora. Please do 3 mock package reviews and link to them here. Once done, can sponsor you. If you have another packaged you would like to bring to Fedora, happy to review that as well.
The package https://src.fedoraproject.org/rpms/ceres-solver was orphaned, but it found a new maintainer and did not remain orphaned for six weeks, so it was not retired, https://docs.fedoraproject.org/en-US/fesco/Policy_for_orphan_and_retired_packages/#_orphan_packages. If it had been retired, and remained retired for eight weeks, https://docs.fedoraproject.org/en-US/fesco/Policy_for_orphan_and_retired_packages/#unorphaning_and_unretiring_packages, *then* a new review would have been required to unretire it. For now, ceres-solver is actively maintained again. I appreciate your interest in contributing to Fedora. Given the above context, I’m closing this *particular* review.
(In reply to Benson Muite from comment #9) > Waiting for your pull request to be merged: > https://src.fedoraproject.org/rpms/ceres-solver/pull-request/8 The pull request was merged. > As a packager you will be able to bring in other software into Fedora, and > to review > software being brought into Fedora. Please do 3 mock package reviews and > link to them here. > Once done, can sponsor you. Thank you, I will do that. > If you have another packaged you would like to bring to Fedora, happy to > review that > as well.