Bug 244686 - Uploaded files are created with wrong perms in vsftpd 1.2.1-3E.12
Uploaded files are created with wrong perms in vsftpd 1.2.1-3E.12
Status: CLOSED ERRATA
Product: Red Hat Enterprise Linux 3
Classification: Red Hat
Component: vsftpd (Show other bugs)
3.9
i386 Linux
high Severity urgent
: ---
: ---
Assigned To: Maros Barabas
: Regression
: 247786 248061 (view as bug list)
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-18 11:13 EDT by hellsing
Modified: 2012-10-10 21:30 EDT (History)
11 users (show)

See Also:
Fixed In Version: RHBA-2007-0757
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-07-27 13:13:23 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to correct upload permissions (655 bytes, patch)
2007-06-28 05:48 EDT, Maros Barabas
no flags Details | Diff
Replacement for rename patch to correct filehandle leak (1.55 KB, patch)
2007-06-28 07:25 EDT, Martin Poole
no flags Details | Diff
Replacement for upload_perms patch to correct permissions problem (2.66 KB, patch)
2007-06-28 07:26 EDT, Martin Poole
no flags Details | Diff
Better patch (529 bytes, text/x-patch)
2007-06-28 08:31 EDT, Maros Barabas
no flags Details
Updated replacement for upload_perms patch (3.06 KB, patch)
2007-06-28 09:40 EDT, Martin Poole
no flags Details | Diff

  None (edit)
Description hellsing 2007-06-18 11:13:50 EDT
Description of problem:

With the last update of vsftpd service, uploaded files are created with 000
rights even if local_umask=002 for example (i refuse anonymous login).

Version-Release number of selected component (if applicable):

vsftpd 1.2.1-3E.12

How reproducible:

All the time i upload files.

Steps to Reproduce:
1. update vsftpd to version 1.2.1-3E.12
2. login to your ftp server
3. upload files and look at the perms
  
Actual results:

with local_umask=002
files created are with perms 000

Expected results:

with local_umask=002
files' rights have to be 664

Additional info:
Comment 1 Craig McElroy 2007-06-18 19:48:55 EDT
We are experiencing this as well and have downgraded back to 1.2.1-3E.6 for the
time being.
Comment 2 Marcelo Giles 2007-06-20 19:28:08 EDT
Same thing. Same package version (vsftpd-1.2.1-3E.12.i386.rpm), same behavior.
Comment 3 Richard Bullington-McGuire 2007-06-20 23:45:00 EDT
I have also experienced this issue.

The unexpected file permissions are not always 000, sometimes they are 065.
Changing local_umask seems to have no effect at all on what the file permissions
end up being.
Comment 4 Mathieu Legaré 2007-06-21 09:25:46 EDT
we're having the same problem. upload file permissions seems pretty random. we
had to downgrade vsftpd.(In reply to comment #0)
Comment 5 Ernie Joynt 2007-06-21 13:24:55 EDT
This problem caused a critical data delivery problem for us.  The severity needs
to be raised to urgent. We'll downgrade, but that is not an acceptable solution
for us.
Comment 7 James Page 2007-06-27 06:39:50 EDT
Ditto the above symptom - caused numerous issues with incoming ftp transfers
over the last few days - have backed out to .6 - please raise the priority of
the issue for resolution
Comment 8 Maros Barabas 2007-06-28 05:48:49 EDT
Created attachment 158105 [details]
Patch to correct upload permissions

Please try this patch. Thanks
Comment 10 Martin Poole 2007-06-28 07:25:36 EDT
Created attachment 158110 [details]
Replacement for rename patch to correct filehandle leak
Comment 11 Martin Poole 2007-06-28 07:26:49 EDT
Created attachment 158111 [details]
Replacement for upload_perms patch to correct permissions problem
Comment 13 Maros Barabas 2007-06-28 08:31:16 EDT
Created attachment 158117 [details]
Better patch

vsftpd-1.2.1-rename.patch and vsftpd-1.2.1-upload_perms.patch stay unchanged.
Comment 17 Martin Poole 2007-06-28 09:40:55 EDT
Created attachment 158123 [details]
Updated replacement for upload_perms patch

This fixes both the permission problem and the handle leak.
Comment 21 Michael Mayer 2007-07-06 12:19:44 EDT
Usage of the test packages in IT#125010 solved the problem for quite a few of my
customers. 
Comment 22 Michael Mayer 2007-07-06 12:21:07 EDT
Usage of the test packages in IT#125010 solved the problem for all three of my
customers who had the problem. Any chances to get a supported update released ? 
Comment 25 Maros Barabas 2007-07-12 04:03:30 EDT
*** Bug 247786 has been marked as a duplicate of this bug. ***
Comment 26 Chris Langlands 2007-07-12 04:20:52 EDT
New RPM today? :)
Comment 27 Maros Barabas 2007-07-13 03:14:20 EDT
*** Bug 248061 has been marked as a duplicate of this bug. ***
Comment 28 Gunther Schlegel 2007-07-17 05:02:08 EDT
this is urgent...
Comment 33 Chris Langlands 2007-07-21 10:08:50 EDT
isn't this dragging on a bit?  it's a pretty nasty bug, introduced with U9.
Comment 36 RHEL Product and Program Management 2007-07-23 06:10:47 EDT
This bugzilla has Keywords: Regression.  

Since no regressions are allowed between releases, 
it is also being marked as a blocker for this release.  

Please resolve ASAP.
Comment 38 Kenny Ferguson 2007-07-24 13:47:38 EDT
I should note that rebuilding from 1.2.1-3E.12 src rpm with the patches kindly
provided, or just trying to build the src rpm period, fails:

[kf@joyce rpm]$ cat /etc/issue
Red Hat Enterprise Linux ES release 3 (Taroon Update 9)

[kf@joyce rpm]$ rpmbuild -ba SPECS/vsftpd.spec

...sysdeputil.c: In function `capset':
sysdeputil.c:152: can't find a register in class `BREG' while reloading `asm'
make: *** [sysdeputil.o] Error 1
make: *** Waiting for unfinished jobs....
error: Bad exit status from /var/tmp/rpm-tmp.52068 (%build)


RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.52068 (%build)...
Comment 39 Kenny Ferguson 2007-07-24 19:59:50 EDT
Nevermind...  was broken dependency.  Needed libcap-devel

(In reply to comment #38)
> I should note that rebuilding from 1.2.1-3E.12 src rpm with the patches kindly
> provided, or just trying to build the src rpm period, fails:
> 
> [kf@joyce rpm]$ cat /etc/issue
> Red Hat Enterprise Linux ES release 3 (Taroon Update 9)
> 
> [kf@joyce rpm]$ rpmbuild -ba SPECS/vsftpd.spec
> 
> ...sysdeputil.c: In function `capset':
> sysdeputil.c:152: can't find a register in class `BREG' while reloading `asm'
> make: *** [sysdeputil.o] Error 1
> make: *** Waiting for unfinished jobs....
> error: Bad exit status from /var/tmp/rpm-tmp.52068 (%build)
> 
> 
> RPM build errors:
>     Bad exit status from /var/tmp/rpm-tmp.52068 (%build)...

Comment 41 Red Hat Bugzilla 2007-07-27 13:13:24 EDT
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2007-0757.html

Note You need to log in before you can comment on or make changes to this bug.