Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Test-Script.spec SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Test-Script-1.02-1.fc7.src.rpm Description: The intent of this module is to provide a series of basic tests for scripts in the bin directory of your Perl distribution. This package is a prerequisite of perl-Test-Inline. Without perl-Test-Script, upgrading/bug-fixing perl-Test-Inline is not possible.
Ping? Would somebody please be so kind to review this? It blocks me from being able to upgrade perl-Test-Inline.
Ping^2. Whom do I need to bribe to review this package? I'd really like to be able to update perl-Test-Inline and to have it in FC-8, but without this package having been add, this won't be possible.
- License tag should be "GPL+ or Artistic". - You don't need to state BuildRequires: perl >= 0:5.005, it will get pulled in by BuildRequires: perl(ExtUtils::MakeMaker) - Missing BuildRequires: perl(Test::More) (and/or perl(Test::Builder), if you'd prefer) Make those changes, and I'll finish the review.
Spot beat me to it - but I'll point out that rpmlint shows that Changes and lib/Test/Script.pm are incorrectly marked as executable.
Thanks for the feedback, updated files available at: http://corsepiu.fedorapeople.org/packages/perl-Test-Script.spec http://corsepiu.fedorapeople.org/packages/perl-Test-Script-1.02-2.fc8.src.rpm
Good: - rpmlint checks return: Nothing - package meets naming guidelines - package meets packaging guidelines - license (GPL+ or Artistic) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (8ceb782be03c0e0ce6f3b7097a327361468628b0) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file As usual, good work with the package Ralf. APPROVED.
New Package CVS Request ======================= Package Name: perl-Test-Script Short Description: Cross-platform basic tests for scripts Owners: corsepiu Branches: FC-6 F-7 InitialCC: fedora-perl-devel-list Cvsextras Commits: yes
cvs done.
Package Change Request ====================== Package Name: perl-Test-Script New Branches: EL-5 Owners: pghmcfc InitialCC: perl-sig Ralf has previously declared his non-interest in EPEL, which is why I am requesting this branch myself.
Git done (by process-git-requests).
perl-Test-Script-1.06-1.el5.1 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/perl-Test-Script-1.06-1.el5.1
perl-Test-Script-1.06-1.el5.1 has been pushed to the Fedora EPEL 5 stable repository.