Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://luk1337.fedorapeople.org/review/rubygem-psych-comments.spec SRPM URL: https://luk1337.fedorapeople.org/review/rubygem-psych-comments-0.1.1-1.fc46.src.rpm Description: Comment-aware YAML Fedora Account System Username: luk1337
Taking. Would you have time to swap review? https://bugzilla.redhat.com/show_bug.cgi?id=2463801
(In reply to Mamoru TASAKA from comment #1) > Taking. > > Would you have time to swap review? > https://bugzilla.redhat.com/show_bug.cgi?id=2463801 I reviewed it, thanks.
Okay. * Not blockers: you may consider the followings (again not blockers) - I don't think ">= 2.4.0" part in "BuildRequires: ruby" is needed: we no longer support such old rubies. - "Rakefile" in ruby system is something like Makefile in autotools system, so this is basically for development purpose, so I don't think this file is needed - I don't think "Gemfile" is useful for packaging. - Well, please check if the files under %{gem_instdir}/bin (i.e. "console" and "setup") are really needed: perhaps they are unneeded. - spec file clean - license correct - source file matches the upstream (sha512sum: c4b29038ada8954ccebf73f9737db0eb7fd62a1fcf980440b696e960f58900a16a6a7397ab76c253dd36607b078dd7c2fc00acd40163b18b3d5bfc0e47fae8b9) - builds cleanly on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=149967784 - tests are executed - installs successfully - minimum functionality works: $ ruby -e 'require "psych/comments" ; puts Psych::Comments::VERSION' 0.1.1 ================================================= This package (rubygem-psych-comments) is APPROVED by mtasaka =================================================
``` diff --git a/rubygem-psych-comments.spec b/rubygem-psych-comments.spec index dc2d2bc..4035ecd 100644 --- a/rubygem-psych-comments.spec +++ b/rubygem-psych-comments.spec @@ -13,7 +13,7 @@ Source0: https://rubygems.org/gems/%{gem_name}-%{version}.gem Source1: %{gem_name}-%{version}-tests.tar.gz BuildRequires: ruby(release) BuildRequires: rubygems-devel -BuildRequires: ruby >= 2.4.0 +BuildRequires: ruby BuildRequires: rubygem(rspec) BuildArch: noarch @@ -53,9 +53,10 @@ popd %files %dir %{gem_instdir} %exclude %{gem_instdir}/.rubocop.yml -%{gem_instdir}/CODE_OF_CONDUCT.md %license %{gem_instdir}/LICENSE.txt -%{gem_instdir}/bin +%doc %{gem_instdir}/README.md +%exclude %{gem_instdir}/bin/console +%exclude %{gem_instdir}/bin/setup %{gem_libdir} %exclude %{gem_cache} %{gem_spec} @@ -64,9 +65,9 @@ popd %doc %{gem_docdir} %exclude %{gem_instdir}/.rspec %doc %{gem_instdir}/CHANGELOG.md -%{gem_instdir}/Gemfile -%doc %{gem_instdir}/README.md -%{gem_instdir}/Rakefile +%doc %{gem_instdir}/CODE_OF_CONDUCT.md +%exclude %{gem_instdir}/Gemfile +%exclude %{gem_instdir}/Rakefile %{gem_instdir}/psych-comments.gemspec %changelog ``` thanks, will apply this diff with your suggestions.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rubygem-psych-comments Monitoring: Wasn't able to create project in Anitya. You can create it manually on: `https://release-monitoring.org`
FEDORA-2026-edb278386f (rubygem-psych-comments-0.1.1-1.fc45) has been submitted as an update to Fedora 45. https://bodhi.fedoraproject.org/updates/FEDORA-2026-edb278386f
FEDORA-2026-4d72f893c5 (rubygem-psych-comments-0.1.1-1.fc44) has been submitted as an update to Fedora 44. https://bodhi.fedoraproject.org/updates/FEDORA-2026-4d72f893c5
FEDORA-2026-cabb2e3d98 (rubygem-psych-comments-0.1.1-1.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2026-cabb2e3d98
FEDORA-2026-edb278386f has been pushed to the Fedora 45 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-edb278386f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-edb278386f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-4d72f893c5 has been pushed to the Fedora 44 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-4d72f893c5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-4d72f893c5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-cabb2e3d98 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-cabb2e3d98 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-cabb2e3d98 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2026-edb278386f (rubygem-psych-comments-0.1.1-1.fc45) has been pushed to the Fedora 45 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-4d72f893c5 (rubygem-psych-comments-0.1.1-1.fc44) has been pushed to the Fedora 44 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2026-cabb2e3d98 (rubygem-psych-comments-0.1.1-1.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.