Spec URL: http://fedorapeople.org/~bpepple/rpms/libepc.spec SRPM URL: http://fedorapeople.org/~bpepple/rpms/libepc-0.3.0-1.fc8.src.rpm Build Log: http://fedorapeople.org/~bpepple/rpms/build.log Description: A library to easily publish and consume values on networks rpmlint results: libepc.src: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 1) libepc-ui.i386: W: no-documentation libepc-ui-devel.i386: W: no-documentation
Here's a link to a F8 scratch build to make reviewing easier: http://koji.fedoraproject.org/koji/taskinfo?taskID=274264
I would appreciate it if you would review my review request (bug 411591)
* Dependency of libepc vs libepc-ui ! Not a blocker, however: [tasaka1@localhost libepc]$ rpm -q --requires libepc > a.txt [tasaka1@localhost libepc]$ rpm -q --requires libepc-ui > b.txt [tasaka1@localhost libepc]$ ( cat b.txt | while read f ; do if ! ( cat a.txt | grep -q "$f" ) ; then echo $f ; fi ; done ) | sed -e 's|=.*$||' | xargs rpm -q --whatprovides | sort | uniq atk-1.20.0-1.fc8 cairo-1.5.2-1.fc9 gtk2-2.12.2-1.fc9 libepc-0.3.0-1.fc9 libepc-ui-0.3.0-1.fc9 pango-1.19.0-1.fc9 This means that apart from libepc, libepc-ui requires only gtk2 (plus packages gtk2 depends on). - Is this what you actually expect? - Especially, does it make sense to split libepc-devel and libepi-ui-devel? * gnutls-devel dependency - While you write explicitly -------------------------------------------------------- BuildRequires: gnutls-devel -------------------------------------------------------- (libsoup-devel requires gnutls-devel) why don't you write "Requires: gnutls-devel" for libepc-devel? libepc-devel actually requires gnutls-devel by /usr/include/libepc-1.0/libepc/tls.h * timestamps - Please use --------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" --------------------------------------------------------- to keep timestamps on installed files (check the timestamps of installed header files, for example). While somethimes this does not work, this usually works for recent Makefiles. * libdir in .pc file on 64bits - (While I only have i386 machine) /usr/lib64/pkgconfig/libepc-1.0.pc contains the line --------------------------------------------------------- prefix=/usr exec_prefix=${prefix} libdir=${exec_prefix}/lib includedir=${prefix}/include --------------------------------------------------------- Here libdir is wrong (and perhaps same for libepc-ui-1.0.pc) * tests/ subdirectory - Maybe some test programs can be executed on %check?
Spec URL: http://fedorapeople.org/~bpepple/rpms/libepc.spec SRPM URL: http://fedorapeople.org/~bpepple/rpms/libepc-0.3.0-2.fc8.src.rpm * Sat Dec 8 2007 Brian Pepple <bpepple> - 0.3.0-2 - Merge ui-devel into devel. - Add patch to fix .pc files. - Add requires for gnutls-devel to -devel. - keep timestamp on installed files. I'll look at adding some of the tests later, since that's not really a blocker. BTW, do you have another package that needs a review, since someone already beat me to the one you listed previously?
I will check your latest srpm later. By the way: > BTW, do you have another package that needs a review, since someone already beat > me to the one you listed previously? I have bug 413561 and bug 414211 .
Spec URL: http://fedorapeople.org/~bpepple/rpms/libepc.spec SRPM URL: http://fedorapeople.org/~bpepple/rpms/libepc-0.3.0-3.fc8.src.rpm * Sat Dec 8 2007 Brian Pepple <bpepple> - 0.3.0-3 - fix rpath. * Sat Dec 8 2007 Brian Pepple <bpepple> - 0.3.0-2 - Merge ui-devel into devel. - Add patch to fix .pc files. - Add requires for gnutls-devel to -devel. - keep timestamp on installed files. Link to scatch builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=283467
For 0.3.0-3: * Dependency for libepc-devel - As we merged libepc-ui-devel into libepc-devel, now libepc-devel should require gtk2-devel, too. Other things are okay. ------------------------------------------------------- This package (libepc) is APPROVED by me -------------------------------------------------------
Mamoru, thanks for the review! New Package CVS Request ======================= Package Name: libepc Short Description: Easy Publish and Consume library Owners: bpepple Branches: InitialCC: Cvsextras Commits: yes
cvs done.
Devel built. Thanks, Mamoru!