9. Relate to TABLE profiles need to change list below: 9.1 Delete the field emailflags from table profiles Added : N/A Removed: FIELD profiles. emailflags 9.2 Delete the field refreshed_when from table profiles Added : N/A Removed: FIELD profiles. refreshed_when
Created attachment 303411 [details] The patch to fix the "delete the refreshed_when "
Just to verify... the effect here is there are changes in the schema which impact altering user email preference settings; doing so isn't something that the catalog supports and thusly this patch simply removes the functions, is that correct?
Rob, :) yes, that is correct, just my thought. Need you and Dave confirm if it is ok.
Created attachment 303720 [details] The patch to fix : 9.1 (refresh_when) and 9.2 (emailflags)
*** Bug 443562 has been marked as a duplicate of this bug. ***
Created attachment 303788 [details] Patch Improve for patching operation. Because all the bugs'patch will be patched into one codes tree, 35a36,51 > @@ -321,14 +300,7 @@ > } > } > } > - > - $dbh->do(q{UPDATE profiles > - SET refreshed_when = ? > - WHERE userid=?}, > - undef, > - $time, > - $id); > - > + > Bugzilla::DB::UnlockTables() unless $already_locked; > } > Above codes' process have been moved into bug 433561 's patch Nicho
s/bug 433561/ bug 443561 Sorry. :)
The patch looks good to me nicho.. regarding the part of the patch that deletes the email filtering based on the user preferences. I think this shouldn't affect hwcert as I think it is related to mailing bugs so not doing the email filtering in hwcert wouldn't annoy anyone I think. otherwise if we will have to replace this code then it is very complicated and it involves a lot of code changing in different modules to use the new table email_setting. Noura
Just to confirm my point the Send() function that requires the email filtering by role only exists in hwcert in the following places: [root@bugdev hwcert-noura]# grep -r Send\( . ./Bugzilla/BugMail.pm:sub Send($;$) { ./Bugzilla/Template.pm: Bugzilla::BugMail::Send($id, $mailrecipients); meaning is it not used by hwcert. Noura
Noura, to confirm, you are happy/otherwise approve this patch does the needed work?
Hey Rob, Yeah the patch looks good to me. Noura
tested and run good