Bug 452456 - Review Request: perl-DateTime-TimeZone - Time zone object base class and factory
Review Request: perl-DateTime-TimeZone - Time zone object base class and factory
Status: CLOSED NOTABUG
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks: F-Spacewalk
  Show dependency treegraph
 
Reported: 2008-06-22 23:29 EDT by Nigel Jones
Modified: 2008-06-23 05:00 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2008-06-23 04:43:36 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Nigel Jones 2008-06-22 23:29:15 EDT
Spec URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone.spec
SRPM URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone-0.7701-1.fc9.src.rpm
Description: 
This class is the base class for all time zone objects. A time zone is
represented internally as a set of observances, each of which describes the
offset from GMT for a given time period.
Comment 1 Parag AN(पराग) 2008-06-23 01:13:52 EDT
rpmlint gave 
perl-DateTime-TimeZone.noarch: E: useless-explicit-provides perl(DateTime::TimeZone)
This package provides 2 times the same capacity. It should only provide it
once.
==> look
https://fedoraproject.org/wiki/Packaging/Perl#Filtering_Requires:_and_Provides
Comment 2 Nigel Jones 2008-06-23 01:41:02 EDT
(In reply to comment #1)
> rpmlint gave 
> perl-DateTime-TimeZone.noarch: E: useless-explicit-provides
perl(DateTime::TimeZone)
> This package provides 2 times the same capacity. It should only provide it
> once.
> ==> look
> https://fedoraproject.org/wiki/Packaging/Perl#Filtering_Requires:_and_Provides
Yeah, for public record... I'm a dummy...

Spec URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone.spec
SRPM URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone-0.7701-2.fc9.src.rpm

Just the provides script fix
Comment 3 Parag AN(पराग) 2008-06-23 01:58:40 EDT
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675992
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
cf56d3770231d59853f4edcd6b56cc45  DateTime-TimeZone-0.7701.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful, 1 test and 26 subtests skipped.
Files=18, Tests=2812,  7 wallclock secs ( 6.91 cusr +  0.19 csys =  7.10 CPU)

APPROVED.
Comment 4 Nigel Jones 2008-06-23 03:33:35 EDT
(In reply to comment #3)
> APPROVED.

Thanks

New Package CVS Request
=======================
Package Name: perl-DateTime-TimeZone
Short Description: Time zone object base class and factory
Owners: nigelj
Branches: F-8 F-9 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes
Comment 5 Paul Howarth 2008-06-23 04:17:52 EDT
This package will almost certainly conflict with the perl-DateTime package that
it is enhancing, since the perl-DateTime package includes the DateTime::TimeZone
and DateTime::Locale modules too; see Bug #167376.
Comment 6 Parag AN(पराग) 2008-06-23 04:32:11 EDT
oops my bad. I just checked this package exists in fedora using
yum search DateTime
Comment 7 Parag AN(पराग) 2008-06-23 04:43:36 EDT
Just looked into perl-DateTime.spec and found that this package is part of
existing perl-DateTime package in fedora.
In this case I am going to CLOSE this review as NOTABUG.
Sorry Nigel for taking your time to update initial submitted package.
Request you to submit a bug to update perl-DateTime-TimeZone in perl-DateTime
package to 0.7701 version.
Comment 8 Paul Howarth 2008-06-23 05:00:59 EDT
(In reply to comment #7)
> Request you to submit a bug to update perl-DateTime-TimeZone in perl-DateTime
> package to 0.7701 version.

I'd also request that perl-DateTime had "provides" for perl-DateTime-TimeZone
and perl-DateTime-Locale too.

Note You need to log in before you can comment on or make changes to this bug.