Red Hat Bugzilla – Bug 455585
Review Request: packagekit-qt - QT bindings for packagekit
Last modified: 2009-01-09 09:05:36 EST
SPEC & SRPM are here http://tuxbrewr.fedorapeople.org/kpackagekit/ Description: QT bindings needed for kpackagekit Build logs http://koji.fedoraproject.org/koji/taskinfo?taskID=718807 Requires Qt4.4 so currently only builds for rawhide. Will be included in F9 when KDE4.1 is released
Quick comments: 1. Is BR: kdelibs-devel really needed here? If so, use kdelibs4-devel instead. 2. Same for qt, use BR: qt4-devel >- 4.4 3. Preferable to use %{cmake} macro like: %{cmake} . instead of manually doing: cmake . -DCMAKE_INSTALL_PREFIX=/usr/
and 4. add %changelog
Done New build logs http://koji.fedoraproject.org/koji/taskinfo?taskID=719895
Linking packagekit-qt to dbus-1 directly (and doing the pkg-config check for it) should not be necessary, QT_QTDBUS_LIBRARY should be enough.
Fixed the dbus linking issue mentioned in comment #4. New SPEC and SRPM in ths usual spot
I'll see about finishing this up.
For posterity, please make sure to increment Release and make changelog entries for each pkg modification esp for those made during review. I mention this only because I didn't see that for the mods made in comment #3 and comment #5
5. Imo, there's a needless -libs subpkg here. I'd recommend getting rid of it, put the -libs files into the main (packagekit-qt) pkg. 6. -devel should Requires: cmake for ownership of %{_datadir}/cmake just noticed, both packagekit-qt and kpackagekit reviews are coming from the same tarball. Why did you submit these separately?
As discussed looks like we have to go with 2 seperate packages. We can start here since kpackagekit requires this package. SPEC and SRPM in the normal spot. Build logs here http://koji.fedoraproject.org/koji/taskinfo?taskID=732307
You missed item 5. 7. Not that it matters much, but the main pkg should be Group: System Environment/Libraries and -devel Group: Development/Libraries license confirmed GPLv2+ (though there's what looks to be some truncation or typos in the source headers in places) source confirmed: 5dd2cffe88091c495f93ffd256faa68e 84745-kpackagekit-0.1-b3.tar.bz2 itesm 5,7 are mostly cosmetic, and I'll trust will be addressed before building. APPROVED.
New Package CVS Request ======================= Package Name: packagekit-qt Short Description: Qt interface for PackageKit. Owners: tuxbrewr Branches: F9 InitialCC: rdieter, kkofler Cvsextras Commits: yes
cvs done.
Hm, there's a few problems/oddities with the latest in CVS (devel): Only a -devel binary package is produced. It contains the (versioned) shared object which I suppose would be enough at runtime non-devel use. If so, the versioned *.so.* should be moved to the main, non-devel package and -devel made dependent on it. Oh, I see Rex already mentioned these (see comments 8 and 10); they remain unaddressed though. There are no %post/%postun /sbin/ldconfig calls even though a shared object is installed into system lib dirs - is that intentional? -devel appears to be lacking some dependencies, see #includes in *.h. At least some qt headers are needed (perhaps (not verified) Requires: qt4-devel?)
Package is dead and has been EOL'd