Bug 455700 - Review Request: kpackagekit - KDE packagekit interface
Review Request: kpackagekit - KDE packagekit interface
Status: CLOSED CURRENTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Rex Dieter
Fedora Extras Quality Assurance
:
Depends On: 455585
Blocks:
  Show dependency treegraph
 
Reported: 2008-07-17 04:57 EDT by Steven M. Parrish
Modified: 2009-01-09 10:02 EST (History)
4 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2009-01-09 10:02:28 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
rdieter: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Steven M. Parrish 2008-07-17 04:57:31 EDT
SPEC, SRPM & Build log are here http://tuxbrewr.fedorapeople.org/kpackagekit/
Description: KPackageKit is the KDE interface for PackageKit.

Depends on packagekit-qt https://bugzilla.redhat.com/show_bug.cgi?id=455585
Comment 1 Rex Dieter 2008-07-17 19:00:58 EDT
A few initial comments:
1.  drop qt4-devel (kdelibs-devel pulls that in already)
2.  BR: kdelibs4-devel
3.  drop hard-coded Requires: PackageKit-libs (auto deps should find this).  Not
sure about 'PackageKit'
4.  drop -DCMAKE_SKIP_RPATH:BOOL=ON (should be included in standard/default
%cmake macro already).
5.  for betas/prelreleases, should use a Release tag something like:
Release: 0.1.%{betaversion}
instead.
Comment 2 Steven M. Parrish 2008-07-18 12:09:04 EDT
all done  spec and srpm in same place.
Comment 3 Steven M. Parrish 2008-07-24 08:06:11 EDT
New SPEC and SRPM uploaded to http://tuxbrewr.fedorapeople.org/kpackagekit/

Build logs here: http://koji.fedoraproject.org/koji/taskinfo?taskID=735971
Comment 4 Rex Dieter 2008-07-24 08:16:24 EDT
close enough.  the remaining items are cosmetic and can be dealt with post
review.  :)  (don't build anything until we have a chance to go over that together)

upstream sources verified:
5dd2cffe88091c495f93ffd256faa68e  84745-kpackagekit-0.1-b3.tar.bz2

license: ok

APPROVED.



Comment 5 Steven M. Parrish 2008-07-24 08:21:59 EDT
New Package CVS Request
=======================
Package Name: kpackagekit
Short Description: KDE packagekit interface
Owners: tuxbrewr
Branches: F9
InitialCC: rdieter, kkofler
Cvsextras Commits: yes
Comment 6 Kevin Fenzi 2008-07-24 14:26:52 EDT
cvs done.
Comment 7 Ville Skyttä 2008-07-25 15:58:09 EDT
(In reply to comment #4)
> the remaining items are cosmetic and can be dealt with post
> review.  :)  (don't build anything until we have a chance to go over that
together)

Doing that here in Bugzilla would almost certainly help more contributors than
doing it in private...

Note You need to log in before you can comment on or make changes to this bug.