Red Hat Bugzilla – Bug 488768
complains about the shipped-with-m-i-t configuration
Last modified: 2014-03-16 23:17:47 EDT
Description of problem:
WARNING: All config files need .conf: /etc/depmod.d/depmod.conf.dist, it will be ignored in a future release.
Version-Release number of selected component (if applicable):
In case of /etc/depmod.d/depmod.conf.dist module-init-tools warns against itself so this should be easy to resolve even in that "future release". The more trouble is that other packages drop files in /etc/depmod.d/. In my sample they belong also to hwdata, udev and pilot-link. What about those?
It pretty much has to be solved in the RPM that owns the file - if udev drops a file in /etc/depmod.d that doesn't have a .conf ending, that's udev's problem. But you'd expect that m-i-t would at least be self-consistent.
The way it has a '.conf.dist' ending makes it seem almost like a packaging whoops (hasn't *everybody* saved a backup copy of foo.c, done a patch, then checked foo.c.dist into the revision system by accident at least once? :)
Not a packaging whoops.
/etc/modprobe.d/modprobe.conf.dist has the exact same issue.
Just did a rawhide install and seeing these warnings repeated 5 times during boot:
WARNING: All config files need .conf: /etc/modprobe.d/floppy-pnp, it will be ignored in a future release.
WARNING: All config files need .conf: /etc/modprobe.d/modprobe.conf.dist, it will be ignored in a future release.
WARNING: All config files need .conf: /etc/modprobe.d/blacklist, it will be ignored in a future release.
It would seem silly to ship the beta with this. If it can't be quickly fixed, just disable the warning for the release? Adding to F11Beta
this isn't a critical issue to the beta, and other changes are already happening in this package upstream that I would not like to introduce at this stage of the freeze. It'll get fixed with updates shortly after the beta goes out. Beta doesn't have to be perfect, far from it.
Actually, these remaining warnings come from hwdata owned files. That package was rebuilt on Friday so I would have thought it was already in the wild but apparently not. It *should* be fixed, but I will keep an eye on it.
We're in a freeze, built packages don't show up in rawhide unless a freeze override is requested of releng, or we unfreeze after the release.
Are there any other changes in hwdata?
I'm not certain another $0.02 is needed, but here's what's in /etc/modprobe.d and not covered by module-init-tools or hwdata on my system.
created by anaconda, though I didn't check any anaconda version newer than
the install media
owned by udev (and I didn't see a version newer in koji than in rawhide)
*** Bug 492732 has been marked as a duplicate of this bug. ***
floppy-pnp fixed in udev-139-3.fc11
I'm also getting these:
WARNING: Deprecated config file /etc/modprobe.conf, all config files belong into /etc/modprobe.d/.
Owned by module-init-tools
WARNING: All config files need .conf: /etc/modprobe.d/blacklist-visor, it will be ignored in a future release.
Owned by pilot-link
*** Bug 494429 has been marked as a duplicate of this bug. ***
blacklist fixed in hwdata-0.225-1.fc11
modprobe.conf.dist fixed in mpdule-init-tools-3.7-7.fc11
floppy-pnp fixed in udev-139-3.fc11
blacklist-visor fixed in pilot-link-0.12.3-20.fc11 (see 494765)
anaconda fixed in anaconda-126.96.36.199-1.fc11
I'm closing this one out. Please reopen if I missed any.
I can confirm all of those messages are gone EXCEPT the anaconda one. I'm using anaconda-188.8.131.52-1
Well, anaconda doesn't own that file. It writes it out during install, and when it writes it out, it now does so as anaconda.conf.
Hmm... so any F10->F11 upgrader will still have the old anaconda file which will produce this warning message?
Well, the problem is this:
That file gets written out during installation. What package should clean it up? And when?
I'm still getting the warning about /etc/modprobe.conf, with rawhide fully updated as of April 21. This can't be fixed by renaming since m-i-t owns it. Since nothing owns /etc/modprobe.d/anaconda, I could fix the warning for it by renaming it as /etc/modprobe.d/anaconda.conf.
# touch /etc/modprobe.conf
# rpm -qf /etc/modprobe.conf
Since modprobe.conf isn't supposed to be there anymore, maybe m-i-t shouldn't own it anymore. I'd call *that* a bug.
For upgraders, it's not necessary to change its name. Just move it into /etc/modprobe.d. Though to be clear, I'm not expressing a position on whether anaconda should do it automatically or the upgrader should do to it manually.
Looks to me like this bug (owning /etc/modprobe.conf) should be reopened, since this is a bug in m-i-t, and the Summary still describes the problem accurately, so it was never fully fixed.
rpm -ql module-init-tools
rpm -V module-init-tools
this package does in fact own a 0-byte /etc/modprobe.conf, which is what I have. So anyone who isn't currently seeing this warning message has a broken m-i-t (until m-i-t is fixed to remove this file from it).
Is the only necessary change here to remove the 0-byte file /etc/modprobe.conf from the package? It's pretty trivial. I know it's not exactly a F11 blocker, but would prevent a lot of duplicate bug reports if it was fixed before F11 comes out.
Ah, I'd not been watching this one since I thought module-init-tools was sorted out, missed the last comments about /etc/modprobe.conf. So the plan is to remove that from the next build of module-init-tools and add a %pre that moves the legacy modprobe.conf to /etc/modprobe.d/anaconda.conf iff it doesn't exist. Does that sound like a reasonable plan?
We think /etc/modprobe.d/local.conf is (in general) a good idea. So we'll make this file and shove in local-specific stuff in there. I'll have the scripts rename modprobe.conf to local.conf and put it into /etc/modprobe.d.
This is fixed now in module-init-tools-3.7-8.fc11
Jon -- to get this into F11, you'll need to file a request for it to be tagged at https://fedorahosted.org/rel-eng/
Although bug 496261 is also on the blocker list, with patch and still needs to be applied/built
I do believe we're waiting on a newer build that migrates the anaconda generated file as well. Jon?
After today's update to module-init-tools-3.7-9.fc11, the warning about /etc/modprobe.conf is gone, the file itself is gone, m-i-t no longer owns it, and there is a file /etc/modprobe.d/local.conf which m-i-t owns. Fixed for me.
This is still not fixed in F11 final, despite the fact that the version is module-init-tools-3.7-9.fc11. I still have a 0-byte /etc/modprobe.conf file owned by module-init-tools, with the corresponding warning in the bootup messages (assuming one has disabled graphical boot).
Never mind, /etc/modprobe.conf is NOT owned by any package, so I can remove it. Nevertheless, I did a clean install, so that file shouldn't be there.