Bug 499985 - grub doesn't draw the splash image when the timeout is non-zero
Summary: grub doesn't draw the splash image when the timeout is non-zero
Keywords:
Status: CLOSED DUPLICATE of bug 473319
Alias: None
Product: Fedora
Classification: Fedora
Component: grub
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Peter Jones
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2009-05-09 20:29 UTC by Nicholas Miell
Modified: 2009-05-31 10:14 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2009-05-31 10:14:50 UTC


Attachments (Terms of Use)
broken behavior (4.43 KB, image/png)
2009-05-09 20:29 UTC, Nicholas Miell
no flags Details
correct behavior (92.92 KB, image/png)
2009-05-09 20:30 UTC, Nicholas Miell
no flags Details
drop in replacement for the existing grub-keystatus.patch (17.24 KB, patch)
2009-05-09 20:33 UTC, Nicholas Miell
no flags Details | Diff

Description Nicholas Miell 2009-05-09 20:29:59 UTC
Created attachment 343232 [details]
broken behavior

Description of problem:

The grub keystatus patch in rawhide/F11 broke the background drawing in the non-zero timeout case, leading to ugliness.

Version-Release number of selected component (if applicable):
grub-0.97-50.fc11.src.rpm

How reproducible:
Always

Steps to Reproduce:
1. Set a non-zero boot timeout
  
Actual results:
see attachment

Expected results:
see the other attachment

Comment 1 Nicholas Miell 2009-05-09 20:30:21 UTC
Created attachment 343233 [details]
correct behavior

Comment 2 Nicholas Miell 2009-05-09 20:33:09 UTC
Created attachment 343234 [details]
drop in replacement for the existing grub-keystatus.patch

This drop-in replacement for the existing grub-keystatus.patch file fixes the problem.

Comment 3 Nicholas Miell 2009-05-09 20:34:12 UTC
The interdiff between grub-keystatus.patch and grub-keystatus-fixed.patch is:

diff -u b/stage2/stage2.c b/stage2/stage2.c
--- b/stage2/stage2.c
+++ b/stage2/stage2.c
@@ -235,7 +235,7 @@
   char *cur_entry = 0;
   struct term_entry *prev_term = NULL;
 
-  if (grub_verbose || grub_timeout != 0)
+  if (grub_verbose)
     cls();
 
   /*

Comment 4 Kyle 2009-05-22 15:38:27 UTC
This appears to be a duplicate of Bug 473319.

Comment 5 Eelko Berkenpies 2009-05-31 10:14:50 UTC

*** This bug has been marked as a duplicate of bug 473319 ***


Note You need to log in before you can comment on or make changes to this bug.