SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rubigen.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-1.fc11.src.rpm Description: A framework to allow Ruby applications to generate file/folder stubs (like the "rails" command does for Ruby on Rails, and the 'script/generate' command within a Rails application during development).
rubygem-rubigen.noarch: W: hidden-file-or-dir /usr/lib/ruby/gems/1.8/gems/rubigen-1.5.2/.autotest Upstream seems to use this, I prefer not to deviate from them. rubygem-rubigen.noarch: E: non-executable-script /usr/lib/ruby/gems/1.8/gems/rubigen-1.5.2/rubygems_generators/application_generator/templates/bin 0644 Template for script, ok to have a shebang, should not be executable.
Attempted to incorporate comments from here: https://bugzilla.redhat.com/show_bug.cgi?id=504469#c1 SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rubigen.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-2.fc11.src.rpm
SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rubigen.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-3.fc11.src.rpm
Assigning.
Some notes for 1.5.2-3: * License tag - As website/javascripts/rounded_corners_lite.inc.js is under LGPLv2+, license tag should be "MIT and LGPLv2+". * Requires - rubygem(hoe) doesn't seem to be needed. Would you check this? * Test - I think as this gem file contains test/ directory, it is preferable to add %check section and execute some tet program there (another gem seems needed, though) By the way, I would appreciate it if you would review my review requests (bug 508416 or bug 508417, both are rubygem related)
(In reply to comment #5) > Some notes for 1.5.2-3: > > * License tag > - As website/javascripts/rounded_corners_lite.inc.js is under > LGPLv2+, license tag should be "MIT and LGPLv2+". Fixed > * Requires > - rubygem(hoe) doesn't seem to be needed. Would you check this? Good Catch. It was needed merely for rebuild, which we don't do. > * Test > - I think as this gem file contains test/ directory, it is preferable > to add %check section and execute some tet program there > (another gem seems needed, though) I would prefer not running the test suite unless absolutely necessary. They seem use rather exotic and poorly-estabilished testing tool chain -- mocha for api mocking and shoulda for just having an extra dependency. I would be really happy if we didn't have to package these, and their dependency chain for Fedora now. > By the way, I would appreciate it if you would review my > review requests (bug 508416 or bug 508417, both are rubygem related) Of course, will do. Sorry for the long delay, I'm going to look into those right now. SPEC: http://v3.sk/~lkundrak/gdc-ruby-stack/SPECS/rubygem-rubigen.spec SRPM: http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-4.fc11.src.rpm
(In reply to comment #6) > SRPM: > http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-4.fc11.src.rpm Seems 404...
(In reply to comment #7) > (In reply to comment #6) > > SRPM: > > http://v3.sk/~lkundrak/gdc-ruby-stack/SRPMS/rubygem-rubigen-1.5.2-4.fc11.src.rpm > > Seems 404... Whoops, sorry, I uploaded noarch package instead. Should be fixed now.
Okay. -------------------------------------------------------- This package (rubygem-rubigen) is APPROVED by mtasaka --------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-rubigen Short Description: A framework to allow Ruby applications to generate file/folder stubs Owners: lkundrak Branches: F-11 EL-5
CVS done.
Thanks a lot, Mamoru (not being sure which part of a Japan name is a given name, to be used when referring to a person :) Imported and built.