Red Hat Bugzilla – Bug 512034
Last modified: 2009-08-08 15:28:34 EDT
Created attachment 353926 [details]
Xchats network dialog has a C_onnect button. This happens new because we fixed a bug in GTK+ where it whould apply mnemonics even though it was not supposed to.
The attached patch should fix this (untested)
OK, I'm applying this trivial fix in Fedora, but this needs to be fixed upstream too. CCing upstream.
Should be fixed in 2.8.6-9.fc12 which is now building.
Created attachment 354251 [details]
Patch using gtk_button_set_use_underline
I was seeing this issue on Fedora 11 with the latest testing gtk2 (2.16.4, 2.16.5), rebuilding 2.8.6-9.fc12 on Fedora 11 did not fix it, it just gives:
(xchat:27688): Gtk-CRITICAL **: gtk_label_set_use_underline: assertion `GTK_IS_LABEL (label)' failed
A working patch uses gtk_button_set_use_underline instead.
Thanks for the fixed patch, should be fixed in 2.8.6-10.fc12 which is now building.
(<rant>This bug (the incorrect patch) would not have happened if an actual object-oriented language like C++ had been used instead of abusing C for OOP. Neither Qt nor GTK-- allow this class of bugs to happen.</rant>)
Sorry about that. The corrected patch is obviously correct.
Build completed, should be fixed for good now, please reopen if the problem persists.
*** Bug 515500 has been marked as a duplicate of this bug. ***
Reopening, needs fixing in F11 too.
*** Bug 516141 has been marked as a duplicate of this bug. ***
xchat-2.8.6-11.fc11 has been submitted as an update for Fedora 11.
xchat-2.8.6-11.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.