Spec URL: http://hicham.fedorapeople.org/jide-oss.spec SRPM URL: http://hicham.fedorapeople.org/jide-oss-2.7.1-1.20090805svn.fc11.src.rpm Description: JIDE Common Layer is Swing component library built on top of Java/Swing. It is also the foundation of other component products from JIDE. This project has over 30 Swing components and over 100k lines of code. It greatly enhanced the default component set provided by Swing and allow developers to focus on business logic layer instead of making components. JIDE Common Layer was originally developed by JIDE Software developers as a foundation in order to build other more advanced components. In April of 2007, JIDE Software decided to open source this common layer so that more and more developers can leverage them instead of wasting time building them again. rpmlint output : none koji build page : http://koji.fedoraproject.org/koji/taskinfo?taskID=1586658
Use the SVN revision in the tarball name and revision, e.g. # SVN revision used %global svnrel 1181 Release: 1.%{svnrel}svn%{?dist} #This is a cvs snapshot, to create this tarball # svn co -r %{svnrel} https://jide-oss.dev.java.net/svn/jide-oss/branches/trunk_2.7.1/ jide-oss --username guest #create the tarball : tar -cjvf jide-oss-2.7.1.tar.bz2 jide-oss ** Still, don't version the jar as it isn't versioned by upstream. http://fedoraproject.org/wiki/Packaging/Java#Package_naming
Also, you can drop BR: dos2unix if you just use https://fedoraproject.org/wiki/PackagingTricks#Remove_DOS_line_endings
the jar is versioned by upstream. I updated the spec file. Spec URL: http://hicham.fedorapeople.org/jide-oss.spec SRPM URL: http://hicham.fedorapeople.org/jide-oss-2.7.1-2.1181svn.fc11.src.rpm Description: JIDE Common Layer is Swing component library built on top of Java/Swing. It is also the foundation of other component products from JIDE. This project has over 30 Swing components and over 100k lines of code. It greatly enhanced the default component set provided by Swing and allow developers to focus on business logic layer instead of making components. JIDE Common Layer was originally developed by JIDE Software developers as a foundation in order to build other more advanced components. In April of 2007, JIDE Software decided to open source this common layer so that more and more developers can leverage them instead of wasting time building them again. rpmlint output : none
(In reply to comment #3) > the jar is versioned by upstream. Sorry, my bad :)
is the package ok now ?
You don't have to create an account to check out, you can use --username guest as implicitly pointed out in comment #1. ** You should send the patches upstream, as they're probably needed by a lot of people. ** rpmlint is clean. existing class files and jars are correctly removed in %prep. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. OK MUST: The package must be named according to the Package Naming Guidelines. OK MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK - Excerpt from LICENSE.txt JIDE Common Layer is a dual-licensed. The two licenses are GPL with classpath exception and free commercial license. The first license is GPL with classpath exception. This is the same license under which the Java platform is released. You can read the license agreement from the link below. GPL v2: http://www.gnu.org/licenses/gpl.txt Classpath Exception: http://www.gnu.org/software/classpath/license.html - SwingWorker is LGPLv2+ but that's compatible with GPLv2. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: The package MUST successfully compile and build into binary rpms. OK MUST: The spec file MUST handle locales properly. N/A MUST: Optflags are used and time stamps preserved. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Debuginfo package is complete. N/A MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. NEEDSWORK - There is a docs/JIDE_Common_Layer_Developer_Guide.pdf, which should go into -doc. (There's a .doc file too, but IMHO the pdf is better.) MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: Desktop files are installed properly. N/A MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. NEEDSWORK - There is a http link to the license in LICENSE.txt, though, so this is not necessary. SHOULD: The package builds in mock. OK ** The package has been APPROVED Before CVS import add the -doc package. (Remember, no need to define it explicitly as noarch since the main package already is noarch.)
the doc package should include the pdf file only?
(In reply to comment #7) > the doc package should include the pdf file only? Yes, unless there's some other (biggish) documentation files I didn't find. I don't think there's is any sense in including the .doc in addition to the .pdf if their contents is identical - it's easier to get the .pdf displayed correctly.
which location should i use for the doc package?
What do you mean by location? %files doc %defattr(-,root,root,-) %doc docs/JIDE_Common_Layer_Developer_Guide.pdf
updated the spec file. Spec URL: http://hicham.fedorapeople.org/jide-oss.spec SRPM URL: http://hicham.fedorapeople.org/jide-oss-2.7.1-3.1181svn.fc11.src.rpm
Summary: User documentation for %{name} ^^^^ Isn't this more like *developer* documentation? :)
updated the spec file. Spec URL: http://hicham.fedorapeople.org/jide-oss.spec
Yes, yes, import the package already! And update the other spec files so I can review them.
New Package CVS Request ======================= Package Name: jide-oss Short Description: Swing component library built on top of Java/Swing Owners: hicham Branches: F-11 InitialCC: hicham
Why no F-10 branch?
New Package CVS Request ======================= Package Name: jide-oss Short Description: Swing component library built on top of Java/Swing Owners: hicham Branches: F-10 F-11 InitialCC: hicham
cvs done.
jide-oss-2.7.1-3.1181svn.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/jide-oss-2.7.1-3.1181svn.fc11
jide-oss-2.7.1-3.1181svn.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/jide-oss-2.7.1-3.1181svn.fc10
jide-oss-2.7.1-3.1181svn.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jide-oss'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-8370
jide-oss-2.7.1-3.1181svn.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update jide-oss'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-8376
jide-oss-2.7.1-3.1181svn.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report.
jide-oss-2.7.1-3.1181svn.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.