Bug 541207 - Review Request: liborigin2 - library for reading OriginLab Origin 7.5 project files
Summary: Review Request: liborigin2 - library for reading OriginLab Origin 7.5 project...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
high
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL: http://soft.proindependent.com/libori...
Whiteboard:
Depends On:
Blocks: 540838
TreeView+ depends on / blocked
 
Reported: 2009-11-25 08:38 UTC by Chen Lei
Modified: 2010-09-19 19:22 UTC (History)
4 users (show)

Fixed In Version: 06042009-2.20100119svn.fc12.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-01-27 13:07:20 UTC
Type: ---
Embargoed:
rdieter: fedora-review+


Attachments (Terms of Use)

Description Chen Lei 2009-11-25 08:38:54 UTC
Description:
Liborigin2 is a library for reading OriginLab Origin 7.5 project files.
OriginLab Origin provides extensive scientific graphing and data analysis
capabilities and includes several new tools that simplify common operations.

Liborigin2 is also a requirement for building qtiplot 0.9.7.10.

SPEC: http://dl.dropbox.com/u/1338197/1/liborigin2.spec
SRPM: http://dl.dropbox.com/u/1338197/1/liborigin2-06042009-0.fc12.src.rpm

Comment 2 Chen Lei 2009-12-01 09:17:02 UTC
koji build succeed http://koji.fedoraproject.org/koji/taskinfo?taskID=1839880

Comment 3 Michael Schwendt 2009-12-05 14:45:58 UTC
One thing that's striking is:

> * Sat Nov 25 2009 Super Cyper <supercyper AT 163 DOT com> - 06042009-1

Certainly you are not named "Super Cyper". I highly recommend you to use your real name, also inside the .spec file and in bugzilla.redhat.com.

[...]

Skimming over the .spec file, it doesn't look bad.

> Name:                   liborigin2
> Group:                  Development/Libraries

Main library packages typically use RPM Group "System Environment/Libraries", since they are used at run-time and not specific to developing/building software.


> %description devel
> This package contains the header files, static libraries

Static libraries are not included, so this description isn't true.


> $ spectool liborigin2.spec 
> Source0: http://prdownload.berlios.de/qtiplot/liborigin2-06042009.zip

This URL points at a web-page instead of the .zip archive. If you cannot find an URL that points at the archive directly (with a specific BerliOS mirror as the last resort), it would be better to follow:
http://fedoraproject.org/wiki/Packaging/SourceURL#Troublesome_URLs

Comment 4 Chen Lei 2009-12-07 16:51:08 UTC
Sorry for my late reply.
I fixed the spec file.

SPEC: http://dl.dropbox.com/u/1338197/1/liborigin2.spec
SRPM: http://dl.dropbox.com/u/1338197/1/liborigin2-06042009-1.fc12.src.rpm

Comment 6 Rex Dieter 2010-01-26 17:40:19 UTC
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1946344

rpmlint output:
liborigin2.x86_64: W: spurious-executable-perm /usr/share/doc/liborigin2-06042009/readme
liborigin2.x86_64: W: spurious-executable-perm /usr/share/doc/liborigin2-06042009/copying
liborigin2-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

Mostly harmless (consider fixing that, but it's not a review blocker).

sources:
8b4443cdc9b30826ded22c6a72e7bea7  liborigin2-20100119.tar.bz2
(confirmed contents match a local svn checkout per instructions in .spec)


License: copying file says GPLv3, but source headers all say GPLv2+, please confirm with upstream developers their intent here.
(I won't consider this a blocker, as it doesn't affect qtiplot's GPLv2+ licensing).

macros: ok

scriptlets: ok

Esthetically, I don't like
Version: 06042009
but as there seems to be no clear upstream version, I don't have any better suggestion either.


APPROVED.

Comment 7 Chen Lei 2010-01-27 03:05:33 UTC
New Package CVS Request
=======================
Package Name: liborigin2
Short Description: liborigin2 is a library for reading OriginLab project files. 
Owners: supercyper
Branches: F-12 F-11
InitialCC:

Comment 8 Chen Lei 2010-01-27 03:11:30 UTC
(In reply to comment #6)
> Scratch build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1946344
> 
> rpmlint output:
> liborigin2.x86_64: W: spurious-executable-perm
> /usr/share/doc/liborigin2-06042009/readme
> liborigin2.x86_64: W: spurious-executable-perm
> /usr/share/doc/liborigin2-06042009/copying
> liborigin2-devel.x86_64: W: no-documentation
> 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
> 
> 
> Esthetically, I don't like
> Version: 06042009
> but as there seems to be no clear upstream version, I don't have any better
> suggestion either.


I fixed the warnings of rpmlint. If upstream has a more explicit version some day, I'll using epoch term to replace old package.

Comment 9 Jason Tibbitts 2010-01-27 05:00:50 UTC
CVS done (by process-cvs-requests.py).

Comment 10 Fedora Update System 2010-01-27 05:32:40 UTC
liborigin2-06042009-2.20100119svn.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/liborigin2-06042009-2.20100119svn.fc11

Comment 11 Fedora Update System 2010-01-27 05:53:04 UTC
liborigin2-06042009-2.20100119svn.fc12.1 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/liborigin2-06042009-2.20100119svn.fc12.1

Comment 12 Fedora Update System 2010-01-29 03:22:31 UTC
liborigin2-06042009-2.20100119svn.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2010-01-29 03:25:09 UTC
liborigin2-06042009-2.20100119svn.fc12.1 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 14 Chen Lei 2010-09-19 05:10:47 UTC
New Package CVS Request
=======================
Package Name: liborigin2
Short Description: Library for reading OriginLab project files
Owners: supercyper
New Branches: el6

Comment 15 Kevin Fenzi 2010-09-19 19:22:17 UTC
Please use a "Package Change Request" ?

http://fedoraproject.org/wiki/Package_SCM_admin_requests

Add a change request and reset the flag when you are ready.


Note You need to log in before you can comment on or make changes to this bug.