Spec URL: http://kalev.fedorapeople.org/smartcardpp.spec SRPM URL: http://kalev.fedorapeople.org/smartcardpp-0.2.0-1.fc14.src.rpm Description: smartcardpp is a set of C++ classes to manage smart card communications and implement basic command primitives. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2517334
I'll review it
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is silent Sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/smartcardpp-* smartcardpp.i686: W: no-manual-page-for-binary card-test smartcardpp-devel.i686: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Sulaco ~/rpmbuild/SPECS: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (BSD). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. Sulaco ~/rpmbuild/SOURCES: sha256sum smartcardpp-0.2.0.tar.bz2* d3b0fee245adf5a24a0ff6d78077c26b991fdef083972dc1f245f6e7b4ea2d29 smartcardpp-0.2.0.tar.bz2 d3b0fee245adf5a24a0ff6d78077c26b991fdef083972dc1f245f6e7b4ea2d29 smartcardpp-0.2.0.tar.bz2.1 Sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. + The package stores shared library files in some of the dynamic linker's default paths, and it calls ldconfig in %post and %postun. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. + Header files are stored in a -devel package. 0 No static libraries. 0 No pkgconfig(.pc) files. + The library file(s) that end in .so (without suffix) is(are) stored in a -devel package. + The -devel package requires the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} + The package does NOT contain any .la libtool archives. 0 Not a GUI application. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Ok, I didn't find any issues, so this package is APPROVED.
Thanks a lot for the very quick review! New Package SCM Request ======================= Package Name: smartcardpp Short Description: Library for accessing smart cards Owners: kalev anttix tuju Branches: f12 f13 f14 InitialCC:
Git done (by process-git-requests).
Builds done, closing the ticket. Thanks!
smartcardpp-0.2.0-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/smartcardpp-0.2.0-1.fc13
smartcardpp-0.2.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/smartcardpp-0.2.0-1.fc14
smartcardpp-0.2.0-1.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/smartcardpp-0.2.0-1.fc12
smartcardpp-0.2.0-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
smartcardpp-0.2.0-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
smartcardpp-0.2.0-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.