Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://kalev.fedorapeople.org/qesteidutil.spec SRPM URL: http://kalev.fedorapeople.org/qesteidutil-0.3.0-1.fc14.src.rpm Description: QEsteidUtil is an application for managing Estonian ID Card. In an user-friendly interface it is possible to change and unlock PINs, examine detailed information about personal data file on the card, extract and view certificates, set up mobile ID, and configure @eesti.ee email. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2520407
I'll review it too.
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is almost silent: Sulaco ~: rpmlint Desktop/qesteidutil-* qesteidutil.i686: W: spelling-error %description -l en_US eesti -> beestings, estival, bestir qesteidutil.i686: W: spelling-error %description -l en_US ee -> i, we, re qesteidutil.i686: W: no-manual-page-for-binary qesteidutil 2 packages and 0 specfiles checked; 0 errors, 3 warnings. Sulaco ~: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. - The License field in the package spec file does NOT match the actual license (LGPLv2 or later). Significant part of the application is derived from Qt library under LGPLv2 with exceptions or GPLv3. So correct license tag would be "LGPLv2+ and LGPLv2 with exceptions or GPLv3". Also please outline in comments this situation. - The file, containing the text of the license(s) for the package, must be included in %doc. So, please, add also qtsingleapplication/LGPL_EXCEPTION.txt qtsingleapplication/LICENSE.GPL3 and qtsingleapplication/LICENSE.LGPL + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. Sulaco ~/rpmbuild/SOURCES: sha256sum qesteidutil-0.3.0.tar.bz2* e6fe37deffc4c4e59921f8b873731826312a5c8c26df63c02e59e2036e76e690 qesteidutil-0.3.0.tar.bz2 e6fe37deffc4c4e59921f8b873731826312a5c8c26df63c02e59e2036e76e690 qesteidutil-0.3.0.tar.bz2.1 Sulaco ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture. See link above. + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files. +/- The package does not bundle copies of system libraries. The only suspicious part is qtsingleapplication - could you, please, specify its status? If it's forked and heavily patched then I believe that we may submit package as is. Otherwise we should try to link against system-wide Qt. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files with a suffix (e.g. libfoo.so.1.1). 0 No devel sub-package. + The package does NOT contain any .la libtool archives. + The package includes a %{name}.desktop file, and this file is properly validated with desktop-file-validate in the %install section. + The package does not own files or directories already owned by other packages. + At the beginning of %install, the package runs rm -rf %{buildroot} (or $RPM_BUILD_ROOT). + All filenames in rpm packages are valid UTF-8. Ok, so the only remaining issues are - Fix License tag + add comment with explanation of the licensing zoo - Explain the status of qtsingleapplication
Thanks for your review, Peter. I'm solving both issues at once by patching qesteidutil to use system qtsingleapplication and removing the bundled copy which should make licensing much simpler. * Thu Oct 07 2010 Kalev Lember <kalev> - 0.3.0-2 - Backported patch to use system qtsingleapplication (#641042) Spec URL: http://kalev.fedorapeople.org/qesteidutil.spec SRPM URL: http://kalev.fedorapeople.org/qesteidutil-0.3.0-2.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2521357
Looks good now. I don't see any other issues, so this package is APPROVED.
New Package SCM Request ======================= Package Name: qesteidutil Short Description: Estonian ID card utility Owners: kalev anttix tuju Branches: f12 f13 f14 InitialCC:
Git done (by process-git-requests).
Package imported and built, closing the ticket.