abrt version: 1.1.13 architecture: x86_64 Attached file: backtrace cmdline: /usr/libexec/telepathy-logger component: telepathy-logger crash_function: _tpl_log_manager_add_message executable: /usr/libexec/telepathy-logger kernel: 2.6.35.6-43.fc14.x86_64 package: telepathy-logger-0.1.5-1.fc14 rating: 4 reason: Process /usr/libexec/telepathy-logger was killed by signal 11 (SIGSEGV) release: Fedora release 14 (Laughlin) time: 1288057644 uid: 500 How to reproduce ----- 1. Pasted multiple lines of text from Evolution into Empathy IRC chat window. 2. Pressed enter. 3. Crashed immediately.
Created attachment 455662 [details] File: backtrace
Package: telepathy-logger-0.1.5-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.Crashes whenever you paste data into IRC from another app.
*** Bug 652932 has been marked as a duplicate of this bug. ***
*** Bug 621653 has been marked as a duplicate of this bug. ***
*** Bug 652180 has been marked as a duplicate of this bug. ***
Package: telepathy-logger-0.1.5-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.opened client 2.crash 3.
Package: telepathy-logger-0.1.5-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) Comment ----- I don't recall what caused this crash.
*** Bug 658665 has been marked as a duplicate of this bug. ***
*** Bug 656254 has been marked as a duplicate of this bug. ***
*** Bug 659726 has been marked as a duplicate of this bug. ***
Package: telepathy-logger-0.1.5-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- I pasted this into an IRC chat window: def get_tags (self): ret = [] for mfg, mdlset in self.ids.iteritems (): mfgl = mfg.lower ().replace (" ", "_") for mdl in mdlset: mdll = mdl.lower ().replace (" ", "_") ret.append ("postscriptdriver(%s;%s;)" % (mfgl, mdll)) return ret
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- Paste any multi-line text containing a blank line into an IRC window. E.g. the following: === This is a test === This will immediately crash telepathy-logger. Comment ----- The above contains a RELIABLE REPRODUCER.
Update on the above reproducer: ANY blank line will cause this crash. Multi-line input isn't required. The error is in log-store-xml.c:454, add_message_text_chat(): if (TPL_STR_EMPTY (body_str)) goto out; On jumping to out, the value of ret is still set to false. The function then returns false without setting an error, which results in the crash. There are 2 ways to go here: either fix the intentional non-logging of blank lines, or just log them. I'd argue that the latter is more correct, especially when you consider that this bug is typically hit when pasting stuff into an IRC window. The blank lines are normally there for a reason. Patch to follow.
Created attachment 464984 [details] Don't suppress blank lines in XML logger I've tested this patch locally and it works for me. It stops the crash, and blank lines are available in the history. koji scratch build available here: http://koji.fedoraproject.org/koji/taskinfo?taskID=2646869
(In reply to comment #14) > Created attachment 464984 [details] > Don't suppress blank lines in XML logger > > I've tested this patch locally and it works for me. It stops the crash, and > blank lines are available in the history. Upstream tested this, and doesn't think it's correct. When they send empty lines, it didn't trigger the problem and get logged. In fact they are not null strings, they are '\n', so TPL_STR_EMPTY() won't return TRUE on them and so that can't be the cause. My fix sets the error before returning FALSE so that when we check the error on _tpl_log_manager_add_message(), it's set and we don't crash. They worked up this patch, which I'll try to test tonight. https://bugs.freedesktop.org/attachment.cgi?id=40835
Setting an error (In reply to comment #15) > My fix sets the error before returning FALSE so that when we check the error on > _tpl_log_manager_add_message(), it's set and we don't crash. > > They worked up this patch, which I'll try to test tonight. > > https://bugs.freedesktop.org/attachment.cgi?id=40835 That's unlikely to be a good idea, as then the output will be full of: CRITICAL ("logstore name=%s: %s. " "Event may not be logged properly.", _tpl_log_store_get_name (store), loc_error->message); The crash is caused because loc_error is NULL. However, that doesn't mean we want these warning messages in the first place.
(In reply to comment #15) > > I've tested this patch locally and it works for me. It stops the crash, and > > blank lines are available in the history. > > Upstream tested this, and doesn't think it's correct. When they send empty > lines, it didn't trigger the problem and get logged. In fact they are not null > strings, > they are '\n', so TPL_STR_EMPTY() won't return TRUE on them and so that can't > be the cause. Incidentally, I've not only tested it, but traced it. It really does return TRUE, and it really is the cause: Breakpoint 1, tpl_entry_text_get_message (self=0xa01520 [TplEntryText]) at entry-text.c:307 307 { (gdb) bt #0 tpl_entry_text_get_message (self=0xa01520 [TplEntryText]) at entry-text.c:307 #1 0x00007f3c22ce08fb in add_message_text_chat (store=0xa0c0f0, message=<value optimized out>, error=0x7fffc91e8368) at log-store-xml.c:453 #2 add_message_text (store=0xa0c0f0, message=<value optimized out>, error= 0x7fffc91e8368) at log-store-xml.c:522 #3 log_store_xml_add_message (store=0xa0c0f0, message=<value optimized out>, error=0x7fffc91e8368) at log-store-xml.c:558 #4 0x00007f3c22cdd4f3 in _tpl_log_manager_add_message ( manager=<value optimized out>, message=0xa01520 [TplEntryText], error= 0x7fffc91e8418) at log-manager.c:301 #5 0x00007f3c22cd4eac in on_sent_signal_cb (proxy=<value optimized out>, arg_Timestamp=1291655127, arg_Type=0, arg_Text=<value optimized out>, user_data=<value optimized out>, weak_object=<value optimized out>) at channel-text.c:1139 #6 0x0000003987a532c4 in _tp_cli_channel_type_text_invoke_callback_for_sent ( tpproxy=0xa772a0 [TplChannelText], error=<value optimized out>, args= 0xa6ba60, generic_callback=0x7f3c22cd4c40 <on_sent_signal_cb>, user_data=<value optimized out>, weak_object=<value optimized out>) at _gen/tp-cli-channel-body.h:12346 #7 0x0000003987ad66bc in tp_proxy_signal_invocation_run (p=0xa73d80) at proxy-signals.c:266 #8 0x000000343e841e33 in g_main_dispatch (context=0x9fc1a0) at gmain.c:2149 ---Type <return> to continue, or q <return> to quit---q Quit (gdb) n 308 g_return_val_if_fail (TPL_IS_ENTRY_TEXT (self), NULL); (gdb) print self $1 = 0xa01520 [TplEntryText] (gdb) print *self $2 = {parent = {parent = {g_type_instance = {g_class = 0xa33eb0}, ref_count = 1, qdata = 0x0}, priv = 0xa01550}, priv = 0xa015a0} (gdb) print self->priv $3 = (TplEntryTextPriv *) 0xa015a0 (gdb) print self->priv->message $4 = (gchar *) 0xa723b0 "" I suggest that something earlier in the process is stripping the \n.
*** Bug 662699 has been marked as a duplicate of this bug. ***
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.open empathy and login 2.got offline message 3.bug occur
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- I don't know what this app is, but apparently it crashed.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.Log into Empathy with a MSN/Hotmail chat account 2. Closed laptop lid causing power hibernation 3. Open laptop lid and Empathy tries to reconnect MSN account Comment ----- Recieved the crash upon restarting the system from hibernation on a laptop.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.unsure. startup 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.logged in 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. Empathy was in idle mode, when you aren't active. 2. Empathy recieved a yahoo message from someone not in contact list. 3.
I get this message when I start up empathy. ** (empathy:2774): WARNING **: Metadata for error domain "geoclue-error-quark" a lready registered Then agter it has been on for a while I get this message: (empathy:2774): tp-glib-CRITICAL **: tp_connection_get_contacts_by_handle: asser tion `tp_connection_is_ready (self)' failed I also get a bunch of these: (empathy:2774): Gdk-CRITICAL **: IA__gdk_window_get_root_coords: assertion `GDK_ IS_WINDOW (window)' failed I don't know if this has anything to do with the logger crash.
The only things I have empathy connected to is Yahoo and irc (irc.freenode.net)
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.Not sure -- maybe closing an IRC conversation window?
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. 2. 3. n
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. Unknown 2. 3. Comment ----- Unknown
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.loaded empathy 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. 2. 3. Creating Empathy account Comment ----- First time running empathy, setting up various messaging account. Crash appeared on last - Yahoo messenger account creation.
The program starts however after crash notification. I'd noticed that facebook chat is only one that doesnt register on the network.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. Launching empathy 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. Launching empathy 2. registering on network 3. crash Comment ----- this is repeating crash...
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. recieving a yahoo message from someone not on your friends list when they spam you. 2. 3. Comment ----- Meaning they will send you html to a link to a site to do something. I should fire up windows and copy and paste a message when it happens in yahoo messenger.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1 application started 2.switch wifi network 3.
This has been fixed in tp-logger-0.2.0, which will be available in >= f15 (since there are api changes it will not be going in f14). If I get some free time, I'll see if it is feasible to back-port the patch which fixes this bug in f14.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.abri empathy me inscribi en la cuenta de msn y salio el error 2. 3. Comment ----- los mensajes llega repetido algunas veces varios renglones seguidos
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.abri empathy me inscribi en la cuenta de msn y salio el error 2. el error ocurre cuando recibo mensajes inmediatamente se reciben aparece el error de duplicacion del mensaja 3. Comment ----- los mensajes llega repetido algunas veces varios renglones seguidos
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. it happened when I tried to open / opened Telepathy 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. the error message just poped up while using telepathy 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.Not sure what caused this, sorry. 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. Nothing special .. 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. IT JUST HAPPENED :d 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. I logged in on Empathy as "invisible" 2. I opened a chat window. 3. I had a conversation.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1.it just happened when loading the application 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: x86_64 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. started empathy IM 2. 3.
Package: telepathy-logger-0.1.7-1.fc14 Architecture: i686 OS Release: Fedora release 14 (Laughlin) How to reproduce ----- 1. logged on for the first time 2. 3.
This message is a notice that Fedora 14 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 14. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At this time, all open bugs with a Fedora 'version' of '14' have been closed as WONTFIX. (Please note: Our normal process is to give advanced warning of this occurring, but we forgot to do that. A thousand apologies.) Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, feel free to reopen this bug and simply change the 'version' to a later Fedora version. Bug Reporter: Thank you for reporting this issue and we are sorry that we were unable to fix it before Fedora 14 reached end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" (top right of this page) and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping