Description of problem: run firefox under gnome-shell and select (in firefox) help->about firefox. try to close this windows with the mouse! you can close the window by pressing Alt+Space and then choose "close". Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
right click on titlebar, select close. Firefox is setting _NET_WM_ALLOWED_ACTIONS and not including _NET_WM_ACTION_CLOSE, Metacity and Mutter obey that and omit the close button.
okay, thanks. escape key also does the trick. The question is: why was the window menu icon removed in gnome-shell?
(In reply to comment #1) > Firefox is setting _NET_WM_ALLOWED_ACTIONS and not including > _NET_WM_ACTION_CLOSE, Metacity and Mutter obey that and omit the close button. Looks like it's because of: http://mxr.mozilla.org/mozilla-central/source/widget/src/gtk2/nsWindow.cpp#3920 3920 gtk_window_set_deletable(GTK_WINDOW(mShell), mBorderStyle & eBorderStyle_close); http://library.gnome.org/devel/gtk/unstable/GtkWindow.html#gtk-window-set-deletable By default, windows have a close button in the window frame. Some window managers allow GTK+ to disable this button. If you set the deletable property to FALSE using this function, GTK+ will do its best to convince the window manager not to show a close button. Depending on the system, this function may not have any effect when called on a window that is already visible, so you should call it before calling gtk_window_show().
(In reply to comment #1) > Firefox is setting _NET_WM_ALLOWED_ACTIONS and not including > _NET_WM_ACTION_CLOSE, Metacity and Mutter obey that and omit the close button. I hope not as _NET_WM_ALLOWED_ACTIONS is managed by the window manager. Could gnome-shell be treating _NET_WM_WINDOW_TYPE_DIALOG windows specially?
(In reply to comment #4) > (In reply to comment #1) > > Firefox is setting _NET_WM_ALLOWED_ACTIONS and not including > > _NET_WM_ACTION_CLOSE, Metacity and Mutter obey that and omit the close button. > > I hope not as _NET_WM_ALLOWED_ACTIONS is managed by the window manager. > > Could gnome-shell be treating _NET_WM_WINDOW_TYPE_DIALOG windows specially? Yeah, I was wrong about that - in investigation, GNOME 3 simply does not include close buttons on any dialogs. (It's hacked up in the window manager theme, in a way I still haven't quite figured out, so I didn't see the change go in, but it is intentional.) So really, the bug here is simpler - if Firefox is going to mark the about dialog as a dialog in GNOME, it needs to be closable without window manager assistance.
Sounds reasonable if "dialog" implies something that is requesting a response from the user. Firefox 3.6 had a close button, so this would be a regression in Firefox 4. Gecko seems to be using _NET_WM_WINDOW_TYPE_DIALOG for all WM_TRANSIENT_FOR windows and perhaps it should not. Gecko may not be alone because "If _NET_WM_WINDOW_TYPE is not set, then managed windows with WM_TRANSIENT_FOR set MUST be taken as [_NET_WM_WINDOW_TYPE_DIALOG]"
*** Bug 685018 has been marked as a duplicate of this bug. ***
*** Bug 708408 has been marked as a duplicate of this bug. ***
*** Bug 706048 has been marked as a duplicate of this bug. ***
*** Bug 702960 has been marked as a duplicate of this bug. ***
*** Bug 716581 has been marked as a duplicate of this bug. ***
*** Bug 677861 has been marked as a duplicate of this bug. ***
*** Bug 704084 has been marked as a duplicate of this bug. ***
*** Bug 716396 has been marked as a duplicate of this bug. ***
*** Bug 728692 has been marked as a duplicate of this bug. ***
We filed this already bug in the upstream database (https://bugzilla.mozilla.org/show_bug.cgi?id=608934) and believe that it is more appropriate to let it be resolved upstream. We will continue to track the issue in the centralized upstream bug tracker, and will review any bug fixes that become available for consideration in future updates. We would strongly encourage you to subscribe to the upstream bug as well (by logging in and adding yourself to the Cc list), so that you can provide whatever information required for the successful resolving of this issue. Thank you for helping to make free software better.