We're still on GWT 2.0.4, which is getting outdated. Besides all of the bug fixes that have gone in since 2.0.4, there are other features we can leverage such as the safe HTML APIs and the logging API. I've tested the upgrade out locally and did not notice any issues while smoke testing the GUI. A patch that does the upgrade is attached.
Note, I'd like to do this right after we release RHQ 4.0, so we have plenty of time to test it before JON 3.0.
Created attachment 490361 [details] upgrades GWT from 2.0.4 to 2.2.0 (also upgrades the maven gwt plugin and gwt-log)
Note the following from the SmartGWT FAQ: "Users on Smart GWT 2.4 and older should make sure they have the GWT 2.3 jars before the Smart GWT jars in their classpath. This is not required for Smart GWT 2.5 and later." It's not possible to specify the order WEB-INF/lib jars are loaded, so we should probably just move up to GWT 2.2, until we have upgraded to SmartGWT 2.5 (not yet released as of today).
SmartGWT 2.5 has been released, so we can now upgrade to GWT 2.3.0 and SmartGWT 2.5.
FutureFeature Improvement
removing bad depends
when we upgrade, we can then add the <strict>true</strict> (-strict) option to the GWT compiler options in the coregui pom.xml. This will force the GWT compiler to fail whenever a class cannot be compiled (today, it just spits out an error message but the compile continues and will still successfully complete - we want the build to fail when this happens).
Both gwt 2.4 and smartgwt 3.0 are out now, so updating the bug title
As part of this upgrade we should enable and test out the 508 accessibility features which smartgwt supports: http://www.smartclient.com/smartgwtee/javadoc/com/smartgwt/client/docs/Accessibility.html
The upgrade work is being done in the feature/gwt-upgrade branch. Any upgrade related bugs should block this bug.
adding attachments of automated test runs and test failures on this branch ....
Created attachment 552408 [details] Image of test failures from testrun
Created attachment 552409 [details] image of specific test failure
documenting that there were 47 test failures from the UI Automation testrun on this branch.
Pushing this to ON_QA since the upgrade is down. Any issues not yet addressed have been made to block the general UXD tracking issue, bug 735475.
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.