Bug 719176 - Edit profile: "duplicate email" is shown even if user press save without changing email
Edit profile: "duplicate email" is shown even if user press save without chan...
Status: CLOSED CURRENTRELEASE
Product: Zanata
Classification: Community
Component: Component-UI (Show other bugs)
1.4.2
Unspecified Unspecified
medium Severity medium
: ---
: ---
Assigned To: Carlos Munoz
Alex Eng
:
: 741804 (view as bug list)
Depends On:
Blocks: zanata-1.5.0
  Show dependency treegraph
 
Reported: 2011-07-05 20:42 EDT by Ding-Yi Chen
Modified: 2012-03-06 19:06 EST (History)
4 users (show)

See Also:
Fixed In Version: 1.5.0
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-03-06 19:06:51 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Ding-Yi Chen 2011-07-05 20:42:49 EDT
Description of problem:
When editing profile, if a user hasn't changed email but click "Save",
then error message "duplicate email" is shown.

This is somewhat misleading.

Version-Release number of selected component (if applicable):
Zanata version 1.4-SNAPSHOT (20110706-0602)

How reproducible:
Always

Steps to Reproduce:
1. Login zanata server 
2. Click "My Profile"
3. Click "Edit profile"
4. Click "Save"
  
Actual results:
Error message "duplicate email"

Expected results:
Either 
1) save name without triggering "email verification"; or 
2) showing "nothing changed" if name is not changed either.


Additional info:
Comment 1 Sean Flanigan 2011-07-06 01:19:00 EDT
Yes, it should save the change regardless, sending an email if and only if the address has changed.  I don't think we need to detect "nothing changed" as such.
Comment 2 Sean Flanigan 2011-09-07 00:32:56 EDT
Assigning to Scrum product owner for prioritisation.
Comment 3 Sean Flanigan 2011-09-27 23:31:39 EDT
*** Bug 741804 has been marked as a duplicate of this bug. ***
Comment 4 David Mason 2011-10-30 20:45:16 EDT
This bug is still present in 1.4.2 deployed on https://translate.zanata.org
Comment 5 Carlos Munoz 2012-02-14 00:40:06 EST
Removed annotation based validation for the profile case, replacing it with "manual" validation in the ProfileAction class. The annotation based validation was moved to the registration page where it made more sense to use it.

See:
https://github.com/zanata/zanata/commit/e4863365d85f32af1eb67c5098a983f4b1ceb866
Comment 6 Alex Eng 2012-02-20 17:36:01 EST
VERIFIED in Zanata version 1.5.0-alpha-2-SNAPSHOT (20120220-1431)

Note You need to log in before you can comment on or make changes to this bug.