Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv-1.0.5-1.fc16.src.rpm Description: Classes for parsing command line arguments with various actions, providing help, grouping options, and more.
I believe this one is ready to review now.
I will review this package
I believe all of the normal blockers for the php-horde-Horde-* packages are fixed with this package.
[MUST] "Requires: php-common >= 5.2.0" to satisfy package.xml [SHOULD] %check is present and all tests pass [OPTIONAL] For readability, you may want to group your Build* and Requires* [OPTIONAL] phpci: You may want to add the following requires: php-gettext, php-reflection, php-spl [OPTIONAL] You may want to require (not BR) the optional PHPUnit ("class Horde_Argv_TestCase extends PHPUnit_Framework_TestCase") [OPTIONAL] You may want to s/pear.horde.org/%{pear_channel}/ and then add "%global pear_channel pear.horde.org"
[OPTIONAL] I'm not sure what the exact Fedora packaging guidelines are for this, but I prefer to be very verbose and would list both the min and max requirements instead of just max (even though you know you don't have < 1.0.0 in Fedora): Requires: php-pear(pear.horde.org/PACKAGE) >= 1.0.0 Requires: php-pear(pear.horde.org/PACKAGE) < 2.0.0
FYI, the Fedora guideline is not to include such dependencies. If you know that all supported releases have at least a certain version, you should not include a versioned dependency on that version. This is all laid out in https://fedoraproject.org/wiki/Packaging:Guidelines#Requires
(In reply to comment #6) > FYI, the Fedora guideline is not to include such dependencies. If you know > that all supported releases have at least a certain version, you should not > include a versioned dependency on that version. This is all laid out in > https://fedoraproject.org/wiki/Packaging:Guidelines#Requires Understood. THANKS Jason! Nick -- Ignore my comment concerning this ;)
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv-2.0.2-1.fc17.src.rpm
Please run the tests during build %check src=$(pwd)/%{pear_name}-%{version} cd %{pear_name}-%{version}/test/$(echo %{pear_name} | sed -e s:_:/:g) phpunit \ -d include_path=$src/lib:.:%{pear_phpdir} \ -d date.timezone=UTC \ . Could also replace the %find_lang with a loop.
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv-2.0.4-3.fc17.src.rpm
Created attachment 693850 [details] phpci.log
Created attachment 693852 [details] php-horde-Horde-Argv-review.txt Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16 Buildroot used: fedora-rawhide-x86_64 Command line :/usr/bin/fedora-review -b 785446
[!]: License field in the package spec file matches the actual license. Most files are BSD Horde/Argv/Translation.php is LGPL v2.1 => BSD and LGPLv2 Just need to fix the License, else everything is ok. Can you please replace my "private" email by my fp.o one ?
Updated Spec URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv.spec SRPM URL: http://nb.fedorapeople.org/horde-reviews/php-horde-Horde-Argv-2.0.4-4.fc17.src.rpm
< License: BSD --- > License: BSD and LGPLv2 Please consider adding a comment about which file use each license. No blocker === APPROVED ===
New Package SCM Request ======================= Package Name: php-horde-Horde-Argv Short Description: Horde command-line argument parsing package Owners: nb remi Branches: el6 f18 InitialCC:
Git done (by process-git-requests).
php-horde-Horde-Image-2.0.3-3.el6, php-horde-Horde-Alarm-2.0.3-3.el6, php-horde-Horde-Lock-2.0.1-3.el6, php-horde-Horde-Argv-2.0.4-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/php-horde-Horde-Argv-2.0.4-4.el6,php-horde-Horde-Lock-2.0.1-3.el6,php-horde-Horde-Image-2.0.3-3.el6,php-horde-Horde-Alarm-2.0.3-3.el6
php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-3.fc18, php-horde-Horde-Argv-2.0.4-4.fc18, php-horde-Horde-Serialize-2.0.1-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/php-horde-Horde-Argv-2.0.4-4.fc18,php-horde-Horde-Serialize-2.0.1-3.fc18,php-horde-Horde-Text-Flowed-2.0.1-3.fc18,php-horde-Horde-Lock-2.0.1-3.fc18,php-horde-Horde-Image-2.0.3-3.fc18,php-horde-Horde-Alarm-2.0.3-3.fc18
Package php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-3.fc18, php-horde-Horde-Argv-2.0.4-4.fc18, php-horde-Horde-Serialize-2.0.1-3.fc18: * should fix your issue, * was pushed to the Fedora 18 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing php-horde-Horde-Alarm-2.0.3-3.fc18 php-horde-Horde-Image-2.0.3-3.fc18 php-horde-Horde-Lock-2.0.1-3.fc18 php-horde-Horde-Text-Flowed-2.0.1-3.fc18 php-horde-Horde-Argv-2.0.4-4.fc18 php-horde-Horde-Serialize-2.0.1-3.fc18' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-2619/php-horde-Horde-Argv-2.0.4-4.fc18,php-horde-Horde-Serialize-2.0.1-3.fc18,php-horde-Horde-Text-Flowed-2.0.1-3.fc18,php-horde-Horde-Lock-2.0.1-3.fc18,php-horde-Horde-Image-2.0.3-3.fc18,php-horde-Horde-Alarm-2.0.3-3.fc18 then log in and leave karma (feedback).
php-horde-Horde-Alarm-2.0.3-3.fc18, php-horde-Horde-Image-2.0.3-3.fc18, php-horde-Horde-Lock-2.0.1-3.fc18, php-horde-Horde-Argv-2.0.4-4.fc18, php-horde-Horde-Serialize-2.0.1-3.fc18, php-horde-Horde-Text-Flowed-2.0.1-4.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report.
php-horde-Horde-Image-2.0.3-3.el6, php-horde-Horde-Alarm-2.0.3-3.el6, php-horde-Horde-Lock-2.0.1-3.el6, php-horde-Horde-Argv-2.0.4-4.el6, php-horde-Horde-Serialize-2.0.1-3.el6, php-horde-Horde-Text-Flowed-2.0.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.