Spec URL: http://vicodan.fedorapeople.org/matespec/mate-menus.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-menus-1.4.0-1.fc17.src.rpm Description: Displays menus for MATE Desktop
Ok there is a ownership issue, change this %files -f %{name}.lang %doc AUTHORS COPYING README %config(noreplace) %{_sysconfdir}/xdg/menus/mate-applications.menu %config(noreplace) %{_sysconfdir}/xdg/menus/mate-settings.menu %{_datadir}/mate-menus/examples/mate-menus-ls.py %{_datadir}/mate-menus/examples/mate-menus-ls.pyc %{_datadir}/mate-menus/examples/mate-menus-ls.pyo %{_datadir}/mate/desktop-directories/ to (mate-menus owns %{_datadir}/mate-menus/ ) %files -f %{name}.lang %doc AUTHORS COPYING README %config(noreplace) %{_sysconfdir}/xdg/menus/mate-applications.menu %config(noreplace) %{_sysconfdir}/xdg/menus/mate-settings.menu %{_datadir}/mate-menus/ %{_datadir}/mate/desktop-directories/
Done. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-menus.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-menus-1.4.0-2.fc17.src.rpm Description: Displays menus for MATE Desktop
please change this %package devel Summary: Development files for mate-menus Requires: %{name}%{?_isa} = %{version}-%{release} Requires: %{name}-libs%{?_isa} = %{version}-%{release} to %package devel Summary: Development files for mate-menus Requires: %{name}-libs%{?_isa} = %{version}-%{release} as the -libs package already requires it.
Done. Spec URL: http://vicodan.fedorapeople.org/matespec/mate-menus.spec SRPM URL: http://vicodan.fedorapeople.org/materpms/srpms/mate-menus-1.4.0-3.fc17.src.rpm Description: Displays menus for MATE Desktop
I'll review this today
1. So, looking at the main package, there's little risk of multilib conflicts (no binaries in particular), so I'm tempted to suggest dropping the -libs subpkg, and just fold all it's content (and scriptlets) into the main pkg (that's how gnome-menus is packaged, fwiw). 2. SHOULD move NOCONFIGURE=1 ./autogen.sh to %prep section 3. SHOULD: noticed /usr/share/mate dir is unowned, will leave to you to decide where in the mate stack would best own this. checking /usr/share/gnome $ rpm -q -f /usr/share/gnome filesystem-3-2.fc17.x86_64 not helpful here. :( 4. SHOULD investigate if we need Requires: redhat-menus here somewhere. (ie, test running this and mate without redhat-menus installed, to see if there's any regressions or oddities) otherwise, naming: ok macros: ok scriptlets: ok sources: ok $ md5sum *.xz 540af0f76e2a28821cf4d32832c784d2 mate-menus-1.4.0.tar.xz licensing: ok items 1-4 aren't strictly blockers, but please do comment on or address them prior to doing any builds. APPROVED.
(In reply to comment #6) > 3. SHOULD: noticed /usr/share/mate dir is unowned, will leave to you to > decide where in the mate stack would best own this. checking > /usr/share/gnome > $ rpm -q -f /usr/share/gnome > filesystem-3-2.fc17.x86_64 > not helpful here. :( > It seems mate-dialogs currently owns /usr/share/mate yum --enablerepo updates-t* whatprovides /usr/share/mate Loaded plugins: fastestmirror, langpacks, presto, refresh-packagekit, remove-with-leaves, show-leaves Loading mirror speeds from cached hostfile * fedora: mirror01.th.ifl.net * rpmfusion-free: mirror01.th.ifl.net * rpmfusion-free-updates: mirror01.th.ifl.net * rpmfusion-nonfree: mirror01.th.ifl.net * rpmfusion-nonfree-updates: mirror01.th.ifl.net * updates: mirror01.th.ifl.net * updates-testing: mirror01.th.ifl.net * updates-testing-debuginfo: mirror01.th.ifl.net * updates-testing-source: mirror01.th.ifl.net mate-dialogs-1.4.0-2.fc17.x86_64 : Displays dialog boxes from shell scripts Repo : updates-testing Matched from: Filename : /usr/share/mate
(In reply to comment #7) > (In reply to comment #6) > > > 3. SHOULD: noticed /usr/share/mate dir is unowned, will leave to you to > > decide where in the mate stack would best own this. checking > > /usr/share/gnome > > $ rpm -q -f /usr/share/gnome > > filesystem-3-2.fc17.x86_64 > > not helpful here. :( > > > > It seems mate-dialogs currently owns /usr/share/mate > > yum --enablerepo updates-t* whatprovides /usr/share/mate > Loaded plugins: fastestmirror, langpacks, presto, refresh-packagekit, > remove-with-leaves, show-leaves > Loading mirror speeds from cached hostfile > * fedora: mirror01.th.ifl.net > * rpmfusion-free: mirror01.th.ifl.net > * rpmfusion-free-updates: mirror01.th.ifl.net > * rpmfusion-nonfree: mirror01.th.ifl.net > * rpmfusion-nonfree-updates: mirror01.th.ifl.net > * updates: mirror01.th.ifl.net > * updates-testing: mirror01.th.ifl.net > * updates-testing-debuginfo: mirror01.th.ifl.net > * updates-testing-source: mirror01.th.ifl.net > mate-dialogs-1.4.0-2.fc17.x86_64 : Displays dialog boxes from shell scripts > Repo : updates-testing > Matched from: > Filename : /usr/share/mate I believe the best solution here is to give mate-session ownership of /usr/share/mate
New Package SCM Request ======================= Package Name: mate-menus Short Description: Displays menus for MATE Desktop Owners: vicodan raveit65 rdieter Branches: f16 f17 f18 InitialCC:
Git done (by process-git-requests).
mate-menus-1.4.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/mate-menus-1.4.0-3.fc18
mate-menus-1.4.0-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/mate-menus-1.4.0-3.fc17
mate-menus-1.4.0-3.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/mate-menus-1.4.0-3.fc16
mate-menus-1.4.0-3.fc18 has been pushed to the Fedora 18 testing repository.
mate-menus-1.4.0-3.fc17 has been pushed to the Fedora 17 stable repository.
mate-menus-1.4.0-3.fc18 has been pushed to the Fedora 18 stable repository.
*** Bug 874722 has been marked as a duplicate of this bug. ***
mate-menus-1.4.0-3.fc16 has been pushed to the Fedora 16 stable repository.