Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 854932

Summary: RESTAPI: missing update impl at /api/disks/xxx
Product: [oVirt] ovirt-engine Reporter: Michael Pasternak <mpastern>
Component: RestAPIAssignee: shani <sleviim>
Status: CLOSED CURRENTRELEASE QA Contact: Daniel <dmaaravi>
Severity: high Docs Contact:
Priority: high    
Version: ---CC: acanan, bsettle, bugs, derez, ebenahar, fgarciad, frolland, gickowic, jeokim, lpeer, oliel, rdlugyhe, rvdwees, scohen, sleviim, srevivo, tnisan
Target Milestone: ovirt-4.4.0Keywords: Automation
Target Release: ---Flags: aoconnor: ovirt-4.4+
dmaaravi: testing_plan_complete+
ylavi: planning_ack+
amureini: devel_ack+
acanan: testing_ack+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
The REST API in the current release adds the following updatable disk properties for floating disks: * For Image disks: provisioned_size, alias, description, wipe_after_delete, shareable, backup, and disk_profile. * For LUN disks: alias, description and shareable. * For Cinder and Managed Block disks: provisioned_size, alias, and description. See http://ovirt.github.io/ovirt-engine-api-model/4.4/#services/disk/methods/update
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-20 20:02:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1080097    
Bug Blocks:    

Description Michael Pasternak 2012-09-06 10:30:46 UTC
Description of problem:

update() implementation is missing

Comment 1 Michael Pasternak 2012-10-09 07:57:27 UTC
actual apli impl. is there, but it throws NotImplemenetedException.

Comment 2 Ori Liel 2012-10-09 10:17:23 UTC
IIRC It's missing because there is not backend support for updating a floating disk, I will verify this

Comment 17 Ori Liel 2012-10-15 13:58:26 UTC
patch posted upstream: 
   http://gerrit.ovirt.org/#/c/8531/

patch merged upstream:
   ce6edc2a2d6372f8d0070f8b148b3df17c047ea7

patch posted downstream: 
   https://gerrit.eng.lab.tlv.redhat.com/#/c/2634/

patch merged downstream: 
   dafff650d80edf9856b48fbbddfb2669b0de5ad3

Comment 18 Michael Pasternak 2012-10-15 14:03:41 UTC
ori, please remove rsdl signature

Comment 19 Ori Liel 2012-10-15 15:13:34 UTC
Added: 

patch posted upstream: 
  http://gerrit.ovirt.org/#/c/8568/

patch merged upstream: 
   95339d2a97dbb14ed76ec8912e494e4df4dea6dc

patch posted downstream:
   https://gerrit.eng.lab.tlv.redhat.com/#/c/2646/

patch merged downstream: 
   b5f3ddddf1b98e33f2a7280f8be8eaf75432a24f

Comment 28 Allon Mureinik 2014-08-31 14:23:34 UTC
*** Bug 1075140 has been marked as a duplicate of this bug. ***

Comment 31 Sandro Bonazzola 2016-05-02 10:00:35 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 32 Yaniv Lavi 2016-05-23 13:16:46 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 33 Yaniv Lavi 2016-05-23 13:20:36 UTC
oVirt 4.0 beta has been released, moving to RC milestone.

Comment 34 Yaniv Kaul 2016-07-18 07:51:35 UTC
Is this going to make it to 4.0? (I assume not).

Comment 35 Yaniv Kaul 2017-02-12 09:38:42 UTC
Tal - it's been open for several years. Is it going into 4.1? If not, please CLOSE-DEFERRED.

Comment 36 Tal Nisan 2017-02-12 13:44:17 UTC
We are planning to have it for 4.2 once the RFE in bug 1080097 will be done REST addition can be done as well, marked this bug as blocked on this RFE

Comment 39 Allon Mureinik 2017-09-12 09:22:14 UTC
Pushing out to show that we aren't committing on delivering this in 4.2.
If it's ready, we can always bring it back to 4.2.

Comment 40 Sandro Bonazzola 2019-01-28 09:41:36 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 43 Daniel 2019-12-25 13:01:30 UTC
Checked and verified on api version 4.4.0-0.13.master.el7.
User can edit alias, description etc'.

Comment 48 Sandro Bonazzola 2020-05-20 20:02:37 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.