Bug 903558
| Summary: | add tab index infrastructure for dialogs | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Jiri Belka <jbelka> |
| Component: | Frontend.WebAdmin | Assignee: | Pavel Stehlik <pstehlik> |
| Status: | CLOSED WONTFIX | QA Contact: | Jiri Belka <jbelka> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | --- | CC: | bazulay, bsettle, bugs, oourfali, pstehlik, rbalakri, Rhev-m-bugs, vszocs, ykaul |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2016-11-23 11:46:05 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1064240 | ||
| Bug Blocks: | 1111976, 1134199, 1139257, 1160374, 1266023 | ||
|
Description
Jiri Belka
2013-01-24 09:51:10 UTC
*** Bug 835870 has been marked as a duplicate of this bug. *** *** Bug 832769 has been marked as a duplicate of this bug. *** important information from duplicated bug 832769: [By Juan] """ Apparently this is a known issue with GWT: http://code.google.com/p/google-web-toolkit/issues/detail?id=2732 """ There are also a couple of "merged" (related/duplicate?) issues: https://code.google.com/p/google-web-toolkit/issues/detail?id=5263 https://code.google.com/p/google-web-toolkit/issues/detail?id=5231 in the last issue, it seems that there is no plan to fix it in the GWT infrastructure; this issue also lists a "workaround" (which is not really a workaround - it is actually "the correct way of doing things"), so maybe we need to do something similar. No news? @Vojtech - can you please look into the list in Comment #0 and let us know what you think? is that something that we need/can solve in the GUI infrastructure level? per dialog level? both (i.e. provide an infra, then each dialog will need to use that infra)? please look also in the problem *and workaround* that I am referring to in Comment #6. thanks. I apologize for completely missing the needinfo on me. I've studied links posted by Einav in comment #6 - following is my understanding. We have two general problems here: 1, modal dialog losing focus, as described in GWT issue #2732 - browser/DOM API doesn't provide efficient way to control/restrict focus on elements - problematic use case: assume the last focusable element in dialog has focus, press TAB, focus is "lost" until user clicks again on some focusable element inside the dialog - proposed solution: add hidden "focus catcher" element that returns focus back to dialog (i.e. its first focusable element) - notes: infra-level fix, affecting all dialogs 2, modal dialog not initializing tab indexes properly - AbstractModelBoundPopupWidget has overridable setTabIndexes method, specific (PresenterWidget) dialogs must override this method and take care of assigning tab indexes to focusable (input) elements - if not done properly, can result in "jumpy" focus change behavior - I belive this is mostly what Jiri was referring to in comment #0 - notes: per-dialog-level fix, since it deals with specific elements of specific dialogs I think that both problems mentioned above should be addressed. low priority, no capacity - pushing to 4.0 for now. Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release. Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone. reopening - still happens & additional info in comment 11. Assigning to Pavel to fix. I don't see us investing in this use-case. Closing as WONTFIX. |