Description of problem: Tab motion in popup dialogs is not working correctly in many places: * New Cluster dialog - tab does not change to 'OK' after last checkbox in General dialog - tab does not change to 'Optimalization' sidebar after last item in General dialog (compare with New Desktop dialog when you can go from General->Initial Run) - tab does not change from 'General' (click on this on sidebar) in 'New Cluster' dialog to its pane with related items (it changes to 'Optimalization') - under 'Optimalization' sidebar, tab doesn't change to its pane with its items - under 'Resilience Policy' sidebar, tab doesn't change to its pane with its items * New Host dialog - tab does not change to 'OK' after last checkbox in General dialog - under 'Power Management' sidebar, tab doesn't change to its pane with its items - under 'SPM' sidebar, tab changes after last checkbox to 'Cancel' * New Logical network dialog - from 'Description' textbox it skips 'Enable VLAN tagging' textbox (the order of items in tab motion is wrong...) - tab does not change to 'Attach/Detach Network to/from Cluster(s)' - tab does not chagne to OK|Cancel * Storage | New domain dialog - please review order, it's wrong with tab motion * Storage | Import preconfigured domain dialog - please review order, it's wrong with tab motion * Add Virtual disk dialog - should tab go to 'Internal External (Direct Lun)'?? (but this would mean the first focus would not be on 'Size' textbox) * New Server Virtual Machine dialog - tab doesn't go to 'Priority for Run/Migration queue:' in 'High Availability' sidepane - tab navigation in 'Customem Properties' does not work * New Pool dialog - tab navigation in 'Customem Properties' does not work * Create new volume dialog - order when moving with <tab> is wrong - OK|Cancel not available when using <tab> * Add users and groups (under Users resource tab) - after 'GO' I cannot change with <tab> to the list of users - Shouldn't be first focus on domain list? * Host -> $host's subpane -> Quota tab -> Add - completely tabless, cannot move with <tab> at all, no focus inside popup window * Cluster -> $cluster's subpane -> General - Edit policy - completely tabless, cannot move with <tab> at all, no focus inside popup window * Cluster -> $cluster's subpane -> Logical Networks -> Assign/Unassign Networks - completely tabless, cannot move with <tab> at all, no focus inside popup window * Storage -> $export_domain's subpane -> Template Import -> Import - completely tabless, cannot move with <tab> at all, no focus inside popup window * Storage -> $export_domain's subpane -> Template Import -> Remove - completely tabless, cannot move with <tab> at all, no focus inside popup window * Virtual Machines -> $vm's subpane -> Networks -> New/Edit - completely tabless, cannot move with <tab> at all, no focus inside popup window * Virtual Machines -> $vm's subpane -> Disks -> Add - 'Attach Disk' not available via <tab> * Users -> $user's subpane -> Event Notifier -> Manage events - completely tabless, cannot move with <tab> at all, no focus inside popup window * 'configure' in header - by default no focus in popup window - if clicking on sidebar item (Roles) <tab> moves to 'System permissions' instead to 'Roles' sidepane - cannot access with <tab> list of roles under Roles - cannot access with <tab> list of permissions under 'System permissions' Version-Release number of selected component (if applicable): sf3 How reproducible: 100% Steps to Reproduce: 1. <tab> moving in described dialogs 2. 3. Actual results: wrong order, no accessible items etc... Expected results: all items accessible with <tab> so i can change then Additional info:
*** Bug 835870 has been marked as a duplicate of this bug. ***
*** Bug 832769 has been marked as a duplicate of this bug. ***
important information from duplicated bug 832769: [By Juan] """ Apparently this is a known issue with GWT: http://code.google.com/p/google-web-toolkit/issues/detail?id=2732 """ There are also a couple of "merged" (related/duplicate?) issues: https://code.google.com/p/google-web-toolkit/issues/detail?id=5263 https://code.google.com/p/google-web-toolkit/issues/detail?id=5231 in the last issue, it seems that there is no plan to fix it in the GWT infrastructure; this issue also lists a "workaround" (which is not really a workaround - it is actually "the correct way of doing things"), so maybe we need to do something similar.
No news?
@Vojtech - can you please look into the list in Comment #0 and let us know what you think? is that something that we need/can solve in the GUI infrastructure level? per dialog level? both (i.e. provide an infra, then each dialog will need to use that infra)? please look also in the problem *and workaround* that I am referring to in Comment #6. thanks.
I apologize for completely missing the needinfo on me. I've studied links posted by Einav in comment #6 - following is my understanding. We have two general problems here: 1, modal dialog losing focus, as described in GWT issue #2732 - browser/DOM API doesn't provide efficient way to control/restrict focus on elements - problematic use case: assume the last focusable element in dialog has focus, press TAB, focus is "lost" until user clicks again on some focusable element inside the dialog - proposed solution: add hidden "focus catcher" element that returns focus back to dialog (i.e. its first focusable element) - notes: infra-level fix, affecting all dialogs 2, modal dialog not initializing tab indexes properly - AbstractModelBoundPopupWidget has overridable setTabIndexes method, specific (PresenterWidget) dialogs must override this method and take care of assigning tab indexes to focusable (input) elements - if not done properly, can result in "jumpy" focus change behavior - I belive this is mostly what Jiri was referring to in comment #0 - notes: per-dialog-level fix, since it deals with specific elements of specific dialogs I think that both problems mentioned above should be addressed.
low priority, no capacity - pushing to 4.0 for now.
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
reopening - still happens & additional info in comment 11.
Assigning to Pavel to fix.
I don't see us investing in this use-case. Closing as WONTFIX.