Bug 920211 - [RFE] [CodeChange] re-organize the dynamic and statistics properties of the disk
Summary: [RFE] [CodeChange] re-organize the dynamic and statistics properties of the disk
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.0.0-rc
: 4.0.0
Assignee: Tal Nisan
QA Contact: Aharon Canan
URL:
Whiteboard:
Depends On: 892596 ovirt_refactor_disk_class_hierarchy
Blocks: 876085
TreeView+ depends on / blocked
 
Reported: 2013-03-11 15:04 UTC by Vered Volansky
Modified: 2016-07-05 08:02 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of: 892596
: 1158463 (view as bug list)
Environment:
Last Closed: 2016-07-05 08:02:02 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.0.0+
acanan: testing_plan_complete-
ylavi: planning_ack+
amureini: devel_ack+
acanan: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 56691 0 master ABANDONED core: Introduce boot field in the DiskVmElement entity 2016-05-18 14:15:00 UTC
oVirt gerrit 56692 0 master ABANDONED core: Remove boot property from the BaseDisk entity 2016-05-18 14:17:02 UTC
oVirt gerrit 57603 0 master MERGED core: Move disks boot and interface properties to DiskVmelement 2016-05-18 20:06:10 UTC

Comment 1 Allon Mureinik 2013-03-11 17:02:23 UTC
While we're at it, DiskImage has a bunch of members that also exist in DiskImageDynamic.
We need to clean this up - either separate it to two classes, or at least have DiskImage contains a DiskImageDynamic instance.

Comment 2 Ayal Baron 2013-03-20 10:40:28 UTC
Allon, please fix title to reflect real issue

Comment 3 Allon Mureinik 2013-03-21 07:14:21 UTC
Some extra details:

database:
disk_image_dynamic is in fact not dynamic data (as in vm_dynamic's sense), but statistics data. Moreover, it is saved for every volume (i.e., entry in the images table) although it's only relevant to the active image.
What should be done: 
1. A real image_dynamic table should be created and the status and size columns of images should be moved there
2. The current disk_image_dynamic should be renamed image_statistics, and and only have a row for each active image.

code:
There are duplicate members in DiskImage and DiskImageDynamic. DiskImage should become a container of BaseDisk+DiskImageDynamic+Image, and have no primitive members of its own

Comment 5 Sandro Bonazzola 2016-05-02 10:07:54 UTC
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.

Comment 7 Aharon Canan 2016-06-08 12:05:19 UTC
following my discussion with Tal no special tests needed here, only regression. 
Moving to verified.

Comment 8 Sandro Bonazzola 2016-07-05 08:02:02 UTC
oVirt 4.0.0 has been released, closing current release.


Note You need to log in before you can comment on or make changes to this bug.