Bug 952341

Back port the upstream fix to 3.1.2 as a patch.

+++ This bug was initially created as a clone of JBoss ON 3.1.3 Bug #952337 +++

+++ This bug was initially created as a clone of JBoss ON 3.2 Bug #887861 +++

+++ This bug was initially created as a clone of Bug #887320 +++

Description of problem:
When you try to add new deployment child to an AS7 resource, the agent raise an  OutOfMemoryError.

Version-Release number of selected component (if applicable):
4.6.0-SNAPSHOT

How reproducible:
Always

Steps to Reproduce:
1. Find a simple WAR to deploy
I tried with Jenkins http://mirrors.jenkins-ci.org/war/latest/jenkins.war
2. Go to an AS7 resource page, Inventory/Child Resources tab.
3. Click the toggle button Create Child/Deployment and upload you WAR, then Next and Finish
4. Go to the Inventory/Child History tab
  
Actual results:
The new Created Child history record ends with status failed. A big stack trace ending with OutOfMemoryError is in the history details (see attached stack trace).

Expected results:
The new Created Child history record ends with status success.

Additional info:
* Attached is the server stack trace. The error is catched and passed to the server so it's reported on the server but actually raised in the agent.
* Deploying the same war to a Tomcat 7 resource works. So it may be a problem only for the AS7 plugin

--- Additional comment from Thomas SEGISMONT on 2012-12-14 17:50:28 CET ---

Created attachment 663660 [details]
Stack trace

--- Additional comment from Charles Crouch on 2012-12-14 18:29:08 CET ---

Notes:  http://mirrors.jenkins-ci.org/war/latest/jenkins.war is 46mb

Is this also a problem in jon311?

--- Additional comment from Thomas Segismont on 2012-12-17 09:16:18 EST ---

Fixed: jon3.1.x - f87210f

Cherry-picked from master - 52bdd6f

--- Additional comment from Charles Crouch on 2012-12-17 10:00:15 EST ---

Setting back to new. Thomas got a little carried away and committed this too the wrong branch. If this gets triaged into the release it will be cherry-picked to release/jon3.1.x

--- Additional comment from Thomas Segismont on 2013-02-14 08:47:57 EST ---

Fix tested on JON 3.2 Alpha. Master commit: 84b4cbc

--- Additional comment from Thomas Segismont on 2013-04-08 17:38:58 EDT ---

Reworked to upgrade to HttpClient 4

master - 21ec5e2

--- Additional comment from Thomas Segismont on 2013-04-09 06:08:00 EDT ---

Reworked to increased delay in AS7 itests to discover all resources
master - 3b18013

--- Additional comment from Thomas Segismont on 2013-04-10 08:20:18 EDT ---

Changes reported to release/jon3.1.x - 89d941d

All unit and integration tests pass on my box and on Jenkins:
https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/RHQ/job/rhq-master/org.rhq$rhq-jboss-as-7-plugin/

Manual testing leads to expected results (see the steps listed in the original description of this bug)

--- Additional comment from Larry O'Leary on 2013-04-15 13:32:19 EDT ---

As per upstream comment, this has been fixed with commit to release/jon3.1.x branch 89d941d. Setting to MODIFIED in case there is a 3.1.3 release.