Bug 971119 - /usr/lib/debug CRC mismatch without build-id
Summary: /usr/lib/debug CRC mismatch without build-id
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rpm
Version: 18
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Panu Matilainen
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 980534
TreeView+ depends on / blocked
 
Reported: 2013-06-05 18:13 UTC by Jan Kratochvil
Modified: 2013-07-11 15:22 UTC (History)
14 users (show)

(edit)
Clone Of:
: 980534 (view as bug list)
(edit)
Last Closed: 2013-07-08 00:54:31 UTC


Attachments (Terms of Use)
/usr/lib/rpm/sepdebugcrcfix and its integration. (17.80 KB, patch)
2013-06-24 18:58 UTC, Jan Kratochvil
no flags Details | Diff
/usr/lib/rpm/sepdebugcrcfix and its integration #2. (19.13 KB, patch)
2013-06-24 21:16 UTC, Jan Kratochvil
no flags Details | Diff
/usr/lib/rpm/sepdebugcrcfix and its integration #3. (19.13 KB, patch)
2013-06-24 21:33 UTC, Jan Kratochvil
no flags Details | Diff

Description Jan Kratochvil 2013-06-05 18:13:26 UTC
Description of problem:
rm -rf /usr/lib/debug/.build-id
GDB stops working.

Version-Release number of selected component (if applicable):
gdb-7.5.1-38.fc18.x86_64

How reproducible:
On one system.

Steps to Reproduce:
gdb keyctl
gdb cal

Actual results:
Reading symbols from /usr/bin/keyctl...Missing separate debuginfo for /usr/bin/keyctl
warning: the debug information found in "/usr/lib/debug//usr/bin/cal.debug" does not match "/usr/bin/cal" (CRC mismatch).

Expected results:
Reading symbols from /usr/bin/keyctl...Reading symbols from /usr/lib/debug/bin/keyctl.debug...done.
Reading symbols from /usr/bin/cal...Reading symbols from /usr/lib/debug/usr/bin/cal.debug...done.

Additional info:

Comment 1 Jan Kratochvil 2013-06-13 13:38:07 UTC
The keyctl problem is due to toplevel symlinks in 'filesystem': Bug 974130

The cal problem is due to dwz: Changing .debug file CRC not updating it in the main file referencing it.

Comment 2 Jan Kratochvil 2013-06-13 17:35:35 UTC
Jakub, do you suggest how to fix it?

I/whoever could write small tool to update CRC in the binary files according to new recomputed CRC from the referenced dwz-ed .debug file.

Comment 3 Jakub Jelinek 2013-06-13 17:39:01 UTC
Maybe, yeah.  dwz doesn't know about the original file, so isn't able to adjust the crc in it.

Comment 4 Jan Kratochvil 2013-06-24 18:58:36 UTC
Created attachment 764751 [details]
/usr/lib/rpm/sepdebugcrcfix and its integration.

/usr/lib/rpm/sepdebugcrcfix and its integration with /usr/lib/rpm/find-debuginfo.sh .

As special package representatives I have tested glibc and kernel and both do not use dwz so sepdebugcrcfix is run there but it does not change the files.
kernel build:
/usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32, matched 1564 CRC32.
/usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32, matched 1486 CRC32.
/usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32, matched 1412 CRC32.
/usr/lib/rpm/sepdebugcrcfix: Updated 0 CRC32, matched 591 CRC32.

It modifies mtime (if the file is updated).  dwz also modifies mtime so it is probably OK.

Comment 6 Jan Kratochvil 2013-06-24 21:16:42 UTC
Created attachment 764787 [details]
/usr/lib/rpm/sepdebugcrcfix and its integration #2.

Comment 7 Jan Kratochvil 2013-06-24 21:33:41 UTC
Created attachment 764790 [details]
/usr/lib/rpm/sepdebugcrcfix and its integration #3.

Comment 8 Panu Matilainen 2013-07-04 08:38:40 UTC
Ugh. I dont question the need for this, but the debuginfo department is starting to get a bit ... thick.

Anyway, added to rawhide now (rpm-4.11.1-2.fc20), lets give it a few days to see if anything breaks before pulling elsewhere. RHEL-7 will obviously need (and benefit from) this as there's a mass-rebuild pending, but what about F19 and F18? Those would only see a limited benefit (through updates) at this point.

Comment 9 Jan Kratochvil 2013-07-04 08:52:11 UTC
wrt the F-18 and F-19 backport:

As all the tools I am aware of already use /usr/lib/debug/.build-id/ this problem should not affect normal users.  OTOH for tools hackers like me I currently use this tool by hand when doing some hand rpm rebuilds needing to load uninstalled .debug file.

Also most used packages also get some updates which would benefit from such a rpmbuild fix backported in F-18/F-19.

Up to you.

Comment 10 Panu Matilainen 2013-07-05 08:56:37 UTC
Ok. Given the rather limited to scope of affected users and distro life cycle, I'll pull it into F19 but leave F18 alone.

Comment 11 Fedora Update System 2013-07-05 09:00:10 UTC
rpm-4.11.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/rpm-4.11.1-1.fc19

Comment 12 Fedora Update System 2013-07-06 00:54:13 UTC
Package rpm-4.11.1-1.fc19:
* should fix your issue,
* was pushed to the Fedora 19 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing rpm-4.11.1-1.fc19'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2013-12411/rpm-4.11.1-1.fc19
then log in and leave karma (feedback).

Comment 13 Fedora Update System 2013-07-08 00:54:31 UTC
rpm-4.11.1-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.