Bug 104015
| Summary: | [PATCH] redhat-logviewer.desktop does not seem to be automatically updated | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Retired] Red Hat Raw Hide | Reporter: | Miloslav Trmac <mitr> | ||||
| Component: | redhat-logviewer | Assignee: | Tammy Fox <tammy.c.fox> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | low | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | 1.0 | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2003-09-15 18:54:30 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 103999 | ||||||
| Attachments: |
|
||||||
|
Description
Miloslav Trmac
2003-09-09 00:23:18 UTC
Created attachment 94402 [details]
Patch to use intltool
Attached patch changes the build process to using intltool for message
extraction (including the .desktop.in file) and automatically building
the .desktop file using translations in the .po files.
The intltool package should be added as a build requirement.
The translations for the .desktop files do not get updated that often, and I would rather update them by hand and use gettext. The main point is that this way adding/changing translations requires
no manual intervention. At the time the patch was created,
Hungarian and Brazilian Portugese translations were missing from the
desktop file and several translations differed from translations
in the PO file.
It seems the desktop file has been last updated on Feb 18. As you point
out, the resulting .desktop file does not change that often, but
that means that it is easy to forget to update it (essentialy,
you'd have to either watch the PO files for changes to the 2 strings
in question or rebuild the .desktop file anyway and compare them).
Integratingthe translations automatically during the build process
makes all this go away.
Furthermore, the strings for translations are extracted directly from
the .desktop.in file, removing the need for ugly warts like this
(LogViewerGui.py:173):
#so the comment string for the desktop file will be translated
commentString = _("Examine system log files")
(including the need to keep this consistent with the English string
in the .desktop file).
Please reconsider your decision.
I rebuilt with the latest desktop a few days ago. I do watch the po commits and rebuild before we release a final product with any new desktop file translations. I do not feel it is worth engineering time to change this. *** Bug 104004 has been marked as a duplicate of this bug. *** *** Bug 104010 has been marked as a duplicate of this bug. *** *** Bug 104005 has been marked as a duplicate of this bug. *** *** Bug 104011 has been marked as a duplicate of this bug. *** *** Bug 104006 has been marked as a duplicate of this bug. *** *** Bug 104007 has been marked as a duplicate of this bug. *** *** Bug 104008 has been marked as a duplicate of this bug. *** *** Bug 104009 has been marked as a duplicate of this bug. *** *** Bug 104012 has been marked as a duplicate of this bug. *** *** Bug 104013 has been marked as a duplicate of this bug. *** *** Bug 104014 has been marked as a duplicate of this bug. *** |