Bug 1265359

Summary:	Add Client capability for windows monitor_config messsage
Product:	Red Hat Enterprise Linux 6	Reporter:	Sandy Stutsman <sstutsma>
Component:	spice-gtk	Assignee:	Default Assignee for SPICE Bugs <rh-spice-bugs>
Status:	CLOSED ERRATA	QA Contact:	SPICE QE bug list <spice-qe-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.8	CC:	bazulay, bmcclain, cfergeau, dblechte, djasa, fidencio, gklein, jjongsma, lsurette, pgrunt, rbalakri, Rhev-m-bugs, rh-spice-bugs, spice-qe-bugs, srevivo, tpelka, ykaul
Target Milestone:	rc
Target Release:	6.8
Hardware:	All
OS:	Windows
Whiteboard:
Fixed In Version:	spice-gtk-0.26-5.el6	Doc Type:	Bug Fix
Doc Text:	Cause: Api for managing monitor's position was not used. Consequence: Virtual monitors change position (coordinates). Fix: Use api for managing monitor position. Result: Monitors stay on expected position.	Story Points:	---
Clone Of:	1248189	Environment:
Last Closed:	2016-05-10 21:16:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1202419, 1244878, 1248189, 1265361, 1265363
Bug Blocks:	1210796, 1244880, 1248196

Comment 2 Fabiano Fidêncio 2015-10-16 08:10:26 UTC

Following https://bugzilla.redhat.com/show_bug.cgi?id=1244878#c4, the upstream commit for spice-gtk is: 8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d.
Moving to POST.

Comment 3 Fabiano Fidêncio 2015-12-08 14:38:26 UTC

(In reply to Fabiano Fidêncio from comment #2)
> Following https://bugzilla.redhat.com/show_bug.cgi?id=1244878#c4, the
> upstream commit for spice-gtk is: 8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d.
> Moving to POST.

Fabiano, you're wrong. The upstream commit is 
http://cgit.freedesktop.org/spice/spice-gtk/commit/?id=2dcadbc1d1a90b282724a5c0a9d8070c3f391f37 as mentioned in the bug description.

Comment 4 Jonathon Jongsma 2015-12-08 21:27:54 UTC

(In reply to Fabiano Fidêncio from comment #3)

> Fabiano, you're wrong. The upstream commit is 
> http://cgit.freedesktop.org/spice/spice-gtk/commit/
> ?id=2dcadbc1d1a90b282724a5c0a9d8070c3f391f37 as mentioned in the bug
> description.

I think we would need both, no? But another issue is that the version of spice-gtk in rhel6 currently uses a bundled version of spice-protocol which does not yet define VD_AGENT_CAP_MONITORS_CONFIG_POSITION. So we'd need to include a patch for that as well.

Comment 5 Fabiano Fidêncio 2015-12-08 21:44:36 UTC

(In reply to Jonathon Jongsma from comment #4)
> (In reply to Fabiano Fidêncio from comment #3)
> 
> > Fabiano, you're wrong. The upstream commit is 
> > http://cgit.freedesktop.org/spice/spice-gtk/commit/
> > ?id=2dcadbc1d1a90b282724a5c0a9d8070c3f391f37 as mentioned in the bug
> > description.
> 
> I think we would need both, no? 

We do need both, but 8b0cd321d5a4d08ccba5845c5f2206e6f8032c1d is the fix for Bug 1265361

> But another issue is that the version of
> spice-gtk in rhel6 currently uses a bundled version of spice-protocol which
> does not yet define VD_AGENT_CAP_MONITORS_CONFIG_POSITION. So we'd need to
> include a patch for that as well.

Yeah. I've patched the bundled spice-protocol. Probably will have to patch the spice-protocol package as well.

Comment 6 Jonathon Jongsma 2015-12-08 21:51:22 UTC

Ah, Yes. I just noticed that there's two different bugs for this feature. Sorry.

Comment 12 errata-xmlrpc 2016-05-10 21:16:39 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0832.html